Page MenuHomePhabricator

CA uses localStorage without guarding for exceptions
Closed, ResolvedPublic


We know that localStorage fails quite easily, mostly due to it being filled up. I was looking at my web inspector a bit today and happened to catch that on CentralAuth we use localStorage, without guarding against setItem exceptions such as QUOTA_EXCEEDED_ERR.

var t=new Date();t.setTime(t.getTime()+86400000);if('localStorage'in window&&window.localStorage)
expires='+t.toGMTString()+'; path=/';}


Event Timeline

TheDJ raised the priority of this task from to Needs Triage.
TheDJ updated the task description. (Show Details)
TheDJ subscribed.
Legoktm triaged this task as Medium priority.May 15 2015, 7:33 PM
Legoktm added a project: good first task.

Change 211295 had a related patch set uploaded (by TheDJ):
Guard against QUOTA_EXCEEDED_ERR for anon users

Change 211295 merged by jenkins-bot:
Guard against QUOTA_EXCEEDED_ERR for anon users

TheDJ claimed this task.
TheDJ removed a project: Patch-For-Review.