Page MenuHomePhabricator
Create Task
Maniphest T96643

Newly created links on subpages are rendered with wrong href
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Tested in Firefox 31.6.0 on English Wikipedia at https://en.wikipedia.org/wiki/User:Mattflaschen_%28WMF%29/Sandbox?veaction=edit:

  1. Blank the surface.
  2. Click link icon.
  3. Paste in File:BetaFeatures-Hovercards-Thumbnail-rtl.svg
  4. Click Insert button
  5. The link in the surface (not the context item) goes to https://en.wikipedia.org/%3AFile%3ABetaFeatures-Hovercards-Thumbnail-rtl.svg .

See T96492: Previewing a link to a File in Flow's VE-mode, opens a broken destination due to /w/

Details

SubjectRepoBranchLines +/-
ce.MWInternalLinkAnnotation: Remove outdated ../ stripping codemediawiki/extensions/VisualEditormaster+0 -13
Customize query in gerrit

Related Objects

Event Timeline

• Mattflaschen-WMF created this task.Apr 21 2015, 3:48 AM
• Mattflaschen-WMF raised the priority of this task from to Needs Triage.
• Mattflaschen-WMF updated the task description. (Show Details)
• Mattflaschen-WMF added a project: VisualEditor-ContentEditable.
• Mattflaschen-WMF added subscribers: • Mattflaschen-WMF, Catrope.
Restricted Application added a project: VisualEditor. · View Herald TranscriptApr 21 2015, 3:48 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Mattflaschen-WMF mentioned this in T96492: Previewing a link to a File in Flow's VE-mode, opens a broken destination due to /w/ .Apr 21 2015, 3:48 AM
Catrope renamed this task from Link to file has wrong href to Newly created links on subpages are rendered with wrong href.Apr 21 2015, 3:54 AM
Catrope claimed this task.
Catrope set Security to None.
gerritbot subscribed.Apr 21 2015, 3:57 AM

Change 205521 had a related patch set uploaded (by Catrope):
ce.MWInternalLinkAnnotation: Remove outdated ../ stripping code

https://gerrit.wikimedia.org/r/205521

gerritbot added a project: Patch-For-Review.Apr 21 2015, 3:57 AM
Catrope mentioned this in T96644: Leading colon for file links should not be included in URLs and link captions.Apr 21 2015, 4:04 AM
In T96643#1223195, @gerritbot wrote:

Change 205521 had a related patch set uploaded (by Catrope):
ce.MWInternalLinkAnnotation: Remove outdated ../ stripping code

https://gerrit.wikimedia.org/r/205521

This addresses the /wiki part being stripped. I filed T96644: Leading colon for file links should not be included in URLs and link captions for the %3A prefix.

gerritbot added a comment.Apr 21 2015, 4:27 AM

Change 205521 merged by jenkins-bot:
ce.MWInternalLinkAnnotation: Remove outdated ../ stripping code

https://gerrit.wikimedia.org/r/205521

Jdforrester-WMF closed this task as Resolved.Apr 21 2015, 4:28 AM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF edited projects, added VisualEditor 2014/15 Q4 blockers, WMF-deploy-2015-04-22_(1.26wmf3); removed Patch-For-Review.
Jdforrester-WMF edited a custom field.
Catrope mentioned this in rEVEDd554d3965866: ce.MWInternalLinkAnnotation: Remove outdated ../ stripping code.Apr 21 2015, 4:28 AM
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q4 blockers board.Apr 21 2015, 4:52 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL