Page MenuHomePhabricator

Move the view of photos on banner lower
Closed, ResolvedPublic

Description

Currently they are positioned too high, can we lower the position of the image (not the window) lower by 50px so we can see more of the top of the image?

Ping @vshchepakina for more clarification

Event Timeline

violetto assigned this task to HuiZSF.
violetto raised the priority of this task from to Needs Triage.
violetto updated the task description. (Show Details)
violetto added a project: Shop-Theme.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 21 2015, 4:31 AM
vshchepakina triaged this task as High priority.Apr 21 2015, 4:34 AM
vshchepakina set Security to None.

The picture is demonstrated as a background of the slide box. By default its position is center center.
I'm trying now to fix the position as center -60px, it seems work for the current pictures.
I think it would be better using JS dynamically compute the position and overwrite to the box

@violetto and @vshchepakina
Are the pictures look good now? Do we need further adjustment please?

They look so much better now. What did you mean by "better using JS
dynamically compute the position and overwrite to the box?"

I meant use JavaScript to compute the position for each banner picture. But pictures vary.
Fixed position is easier. If we change the banner pictures in the future, please consider to save some more upper room for the pictures.

Ah, ok. When we get to a more complicated situation we'll consider JS
option.

Thanks @violetto
Will close this task :)

HuiZSF closed this task as Resolved.Apr 23 2015, 6:15 PM