Popups doesn't work on a fresh install
Closed, InvalidPublic

Description

I want to include Popups extension on a project but it does not work. I did a fresh install [0] with only the Popups and the requirements, but it does not work.

No error at js console nor at the nginx log. There is no popup and the title of the anchor is not showed.

MW 1.25
PHP 5.5.9-1
MySQL 5.5.41
Popups – (21f7c83)

[0] http://beta.programaseducativosaragon.es
[1] http://beta.programaseducativosaragon.es/index.php?title=Special:Version

Lmorillas updated the task description. (Show Details)
Lmorillas raised the priority of this task from to Needs Triage.
Lmorillas added a project: Page-Previews.
Lmorillas added a subscriber: Lmorillas.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 21 2015, 4:03 PM
Lmorillas updated the task description. (Show Details)Apr 21 2015, 4:12 PM
Lmorillas set Security to None.

Thanks for reporting this @Lmorillas. While I try to figure out why Popups is misbehaving, could you update the New Page to the following WikiText and test again?

Vivamus scelerisque congue arcu, ac viverra purus ullamcorper ut. Etiam at euismod elit. Sed pharetra bibendum sodales. Vivamus sollicitudin augue et lorem faucibus sagittis. Pellentesque habitant morbi tristique senectus et netus et malesuada fames ac turpis egestas. Pellentesque euismod felis ante, eget accumsan ligula eleifend non. Pellentesque viverra lectus ac magna malesuada porttitor. Lorem ipsum dolor sit amet, consectetur adipiscing elit. Aliquam consequat dolor auctor facilisis fringilla. Pellentesque dictum elit bibendum, faucibus purus a, tincidunt nisl. Integer mauris augue, interdum vel arcu ac, aliquet egestas ante. Ut ut accumsan lacus. Nam dolor leo, rhoncus id lobortis ac, luctus eget tortor.

== New Page ==

New page for testing

* New page for testing
* New page for testing
* New page for testing

Done, @Prtksxna It works now.

Updating New Page seems to have helped -

Hovercards requests TextExtracts to get text only from the intro section of the page. So, if there is no text before the first section, nothing is returned and it does not render a Hovercard.
However, in such a case, it should not be emptying the title. I'll work on a fix.

I don't know if it's the same issue, but Popups doesn't expand the templates. See [1].

[1] http://programaseducativosaragon.es/wiki/Colegios

I don't know if it's the same issue, but Popups doesn't expand the templates. See [1].
[1] http://programaseducativosaragon.es/wiki/Colegios

That is definitely intended behavior. Popups is meant to quickly look at the intro text of a page, it does so using the TextExtracts extension. You can write new renderers for Popups to display different kinds of information from a page, but it doesn't support this template expansion right now.

Change 205638 had a related patch set uploaded (by Prtksxna):
Stop emptying link title if a TextExtract was not returned

https://gerrit.wikimedia.org/r/205638

Maybe it should be documented better this hovercards behaviour. I did read nothing before about this "Hovercards requests TextExtracts to get text only from the intro section of the page".

I don't know if it's the same issue, but Popups doesn't expand the templates. See [1].
[1] http://programaseducativosaragon.es/wiki/Colegios

That is definitely intended behavior. Popups is meant to quickly look at the intro text of a page, it does so using the TextExtracts extension. You can write new renderers for Popups to display different kinds of information from a page, but it doesn't support this template expansion right now.

Thanks, @Prtksxna Is it documented how to write a new renderer for Popups? I'll investigate.

Maybe it should be documented better this hovercards behaviour. I did read nothing before about this "Hovercards requests TextExtracts to get text only from the intro section of the page".

Sorry for the lack of documentation. I have updated Extension:Popups now.

Thanks, @Prtksxna Is it documented how to write a new renderer for Popups? I'll investigate.

Its not documented in depth, but I've added a new section in Extension:Popups that has some useful links—

Jdlrobson triaged this task as Lowest priority.Sep 23 2015, 6:03 PM
Jdlrobson added a subscriber: Jdlrobson.

Patch is -1ed but should be simple to fix up.

Jdlrobson changed the task status from Open to Stalled.Oct 1 2015, 8:38 PM
Prtksxna changed the task status from Stalled to Open.Nov 3 2015, 3:00 PM

Updated the patch.

Thanks @Prtksxna Some feedback for you on the patch.

@Prtksxna still hoping for a response! Keen to get this off the backlog!

Jdlrobson changed the task status from Open to Stalled.Dec 14 2015, 9:18 PM
Prtksxna closed this task as Invalid.
Prtksxna claimed this task.

Moved the title attribute issue to T123460: Popups unnecessarily removes the title attribute of links . There was no other issue in the fresh install.