Page MenuHomePhabricator

Phone screen improvements on Adding to collection modal
Closed, ResolvedPublic3 Estimated Story Points

Description

See T95628 for context.

Screenshot_2015-04-09-14-46-42.png (1×1 px, 271 KB)

Adding to collection modal is too space inefficient in portait phones making the experience painful.

As much as I like it the star at the top takes too much space on the phone screen :S There are things we could do to improve this modal:

Plz test throughly in several devices/screen sizes.

Event Timeline

Jhernandez raised the priority of this task from to Needs Triage.
Jhernandez updated the task description. (Show Details)
Jhernandez moved this task to In Analysis on the Gather Sprint Forward board.
Jhernandez set Security to None.
Jhernandez edited a custom field.

@Jhernandez @MSyed. Yes! Moiz and I discussed this very issue on monday and came to similar conclusions. Moiz the only thing we discussed differently was removing image rather than halving it...I think such a small image would probably not be helpful in most cases.

@Jhernandez edited descriptions (used strikethrough) and added one item

Change 210088 had a related patch set uploaded (by Jhernandez):
Improve star styles on phones

https://gerrit.wikimedia.org/r/210088

Change 210088 merged by jenkins-bot:
Improve star styles on phones

https://gerrit.wikimedia.org/r/210088

Change 210112 had a related patch set uploaded (by Jhernandez):
Improve spacing in the add to collection overlay.

https://gerrit.wikimedia.org/r/210112

@JKatzWMF regarding change text of input box to "name collection" (currently the suggested text gets cutoff) is that the gray text inside the input?

Something like this?:

Screen Shot 2015-05-11 at 8.37.59 PM.png (190×360 px, 21 KB)

Looks a little weird to me. I would do Name of collection or Collection name (but this last one may be cut out) or just plain Name.

Change 210112 had a related patch set uploaded (by Jhernandez):
Improve spacing in the add to collection overlay.

https://gerrit.wikimedia.org/r/210112

⬆️ This one needs reviewing. Feel free to move back to In development or -1 when reviewed if it isn't finished then.

Change 210112 merged by jenkins-bot:
Improve spacing in the add to collection overlay.

https://gerrit.wikimedia.org/r/210112

Is it just the placeholder that needs changing now @Jhernandez ?

Change 211920 had a related patch set uploaded (by Jhernandez):
Invert placeholder text on create collection input

https://gerrit.wikimedia.org/r/211920

Change 211920 merged by jenkins-bot:
Invert placeholder text on create collection input

https://gerrit.wikimedia.org/r/211920