Page MenuHomePhabricator
Create Task
Maniphest T96866

Update API query continuation usage in MobileFrontend for future change of default
Closed, ResolvedPublic
Actions

Description

In the not too distant future, the default for continuation for API action=query will be changing from the current "raw" format to a more user-friendly format, see here for the most recent announcement of this planned change.

This extension appears to be using query-continue, and so will probably be affected by this change. If you wish to continue using the "raw" format, specify the 'rawcontinue' parameter in your API queries. To be ready for the new format (documented here), specify the 'continue' parameter with the empty string as a value in the initial query.

Details

SubjectRepoBranchLines +/-
Update WatchListApi API query continuationmediawiki/extensions/MobileFrontendmaster+61 -35
Update PhotoListApi API query continuationmediawiki/extensions/MobileFrontendmaster+14 -16
Customize query in gerrit

Related Objects
Search...

Event Timeline

Anomie created this task.Apr 22 2015, 3:08 PM
Anomie raised the priority of this task from to Needs Triage.
Anomie updated the task description. (Show Details)
Anomie added projects: MediaWiki-Action-API, MobileFrontend.
Anomie moved this task to Non-core-API stuff on the MediaWiki-Action-API board.
Anomie subscribed.
Restricted Application added a project: Web-Team-Backlog. · View Herald TranscriptApr 22 2015, 3:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Anomie added a parent task: T96858: Use "new" continuation by default.Apr 22 2015, 3:11 PM
• KLans_WMF moved this task from Incoming to 2016-17 Q2 on the Web-Team-Backlog board.Apr 22 2015, 5:11 PM
Florian subscribed.Apr 22 2015, 6:13 PM
• KLans_WMF renamed this task from Update API query continuation usage for future change of default to (2) Update API query continuation usage for future change of default.Apr 22 2015, 6:16 PM
• KLans_WMF set Security to None.
• KLans_WMF moved this task from 2016-17 Q2 to 2015-16 Q3 on the Web-Team-Backlog board.Apr 23 2015, 9:11 PM
• KLans_WMF added a project: Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story.Apr 27 2015, 6:45 PM
• KLans_WMF renamed this task from (2) Update API query continuation usage for future change of default to Update API query continuation usage for future change of default.Apr 27 2015, 6:56 PM
• KLans_WMF edited a custom field.
• KLans_WMF removed a project: Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story.Apr 27 2015, 7:22 PM
• KLans_WMF moved this task from 2015-16 Q3 to 2016-17 Q2 on the Web-Team-Backlog board.
• KLans_WMF moved this task from 2016-17 Q2 to 2015-16 Q3 on the Web-Team-Backlog board.Apr 29 2015, 8:33 PM
• KLans_WMF added a project: Mobile-Web-Sprint-47-Undercover-Brother.May 6 2015, 6:23 PM
• KLans_WMF edited a custom field.
• KLans_WMF moved this task from Needs Analysis to To Do on the Mobile-Web-Sprint-47-Undercover-Brother board.
phuedx claimed this task.May 12 2015, 2:00 PM
phuedx moved this task from To Do to Doing on the Mobile-Web-Sprint-47-Undercover-Brother board.
phuedx moved this task from Doing to Code Review on the Mobile-Web-Sprint-47-Undercover-Brother board.May 12 2015, 3:55 PM
gerritbot subscribed.May 12 2015, 3:56 PM

Change 210383 had a related patch set uploaded (by Phuedx):
Update PhotoListApi API query continuation

https://gerrit.wikimedia.org/r/210383

gerritbot added a project: Patch-For-Review.May 12 2015, 3:56 PM
gerritbot added a comment.May 12 2015, 4:04 PM

Change 210383 merged by jenkins-bot:
Update PhotoListApi API query continuation

https://gerrit.wikimedia.org/r/210383

phuedx mentioned this in rEMFRc5991dfc3358: Update PhotoListApi API query continuation.May 12 2015, 4:04 PM
phuedx mentioned this in rMEXT66b983d02e45: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….
• bmansurov moved this task from Code Review to Ready for Signoff on the Mobile-Web-Sprint-47-Undercover-Brother board.May 12 2015, 8:01 PM
Anomie added a comment.May 12 2015, 8:57 PM

I note that Gerrit change 210383 seems to have fixed one instance, but I still see query-continue usage in resources/mobile.watchlist/WatchListApi.js and some qunit tests.

phuedx added a comment.May 13 2015, 9:12 AM

Yup. Not sure why this is in Ready for Signoff yet. I shouldn't have put it in Code Review before submitting the patch for the WatchListApi class.

phuedx moved this task from Ready for Signoff to Doing on the Mobile-Web-Sprint-47-Undercover-Brother board.May 13 2015, 9:13 AM
gerritbot added a comment.May 13 2015, 12:42 PM

Change 210679 had a related patch set uploaded (by Phuedx):
Update WatchListApi API query continuation

https://gerrit.wikimedia.org/r/210679

phuedx moved this task from Doing to Code Review on the Mobile-Web-Sprint-47-Undercover-Brother board.May 13 2015, 12:43 PM
• bmansurov subscribed.May 13 2015, 3:24 PM

I moved it to "Ready for Signoff" because the change had been merged. There was no mention of follow up patches anywhere.

phuedx mentioned this in T98985: Add 'fromtitle' parameter to action=watchlistraw.May 13 2015, 5:27 PM
gerritbot added a comment.May 21 2015, 2:59 PM

Change 210679 merged by jenkins-bot:
Update WatchListApi API query continuation

https://gerrit.wikimedia.org/r/210679

Diffusion mentioned this in rMEXT356a2f1633ca: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….May 21 2015, 2:59 PM
phuedx mentioned this in rEMFR9aa651325d7b: Update WatchListApi API query continuation.May 21 2015, 2:59 PM
phuedx added a comment.May 21 2015, 4:57 PM

There won't be any more follow-up patches.

phuedx removed a project: Patch-For-Review.May 21 2015, 4:57 PM
phuedx moved this task from Code Review to Ready for Signoff on the Mobile-Web-Sprint-47-Undercover-Brother board.
• bmansurov unsubscribed.May 21 2015, 5:13 PM
phuedx closed this task as Resolved.May 21 2015, 6:38 PM
phuedx moved this task from Ready for Signoff to Done on the Mobile-Web-Sprint-47-Undercover-Brother board.
Legoktm renamed this task from Update API query continuation usage for future change of default to Update API query continuation usage in MobileFrontend for future change of default.Jun 22 2015, 10:06 PM
• Phabricator_maintenance moved this task from 2015-16 Q3 to 2014-15 Q4 on the Web-Team-Backlog board.Mar 7 2018, 1:19 AM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL