Currently there are no tests encompassing the routes exposed by the service. Code coverage reports:
File Statements Branches Functions Lines lite.js 38.24% (13 / 34) 0% (0 / 4) 16.67% (1 / 6) 38.24% (13 / 34) page.js 18.83% (42 / 223) 0% (0 / 70) 3.13% (1 / 32) 18.83% (42 / 223)
These numbers (especially statements and branches) should be at least 80%. Please write the tests.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add tests for Lite route. | mediawiki/services/mobileapps | master | +85 -0 | |
| Add tests for mobileapp-page | mediawiki/services/mobileapps | master | +130 -10 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | akosiaris | T92627 Deployment of Mobile App's service on the SCB cluster | |||
| Resolved | • bearND | T96870 Add proper tests for MobileApps service routes |
Change 216037 had a related patch set uploaded (by BearND):
Add tests for mobileapp-page
My first patch set of the test patch (which was based on earlier code) had > 90% coverage for the mobileapp-page routes.
The coverage dropped after I rebased the Parsoid patch. In a later patch I'll look into adding the edit buttons for the sections back, which should help using some of the current dead code.
@Dbrant is going to add tests for the mobileapp-lite routes.
@moborvac Would you mark this task as resolved? Can we get the service into the SCA cluster now? Or what is still needed? Thank you!
There should be some tests for the lite routes as well, since it will enter production as well. IMHO, that shouldn't be too hard (more or less the same tests could apply to the lite version as well, if I'm not mistaken).
After that, there is the diagram to be given to ops, I'll post more info on that in the parent task.
Change 217520 had a related patch set uploaded (by Dbrant):
Add tests for Lite route.