Page MenuHomePhabricator

undefined Flow history
Closed, ResolvedPublic

Description

On this Flow history ("Pineapple surprise" on mediawiki's Talk:Sandbox) I see two undefined rows:

Topic on Talk:Sandbox
< Talk:Sandbox
undefined
undefined

and
https://www.mediawiki.org/w/index.php?title=Topic:Sfecvd42treskaxl
is empty.

Details

Related Gerrit Patches:

Event Timeline

He7d3r created this task.Apr 22 2015, 8:28 PM
He7d3r raised the priority of this task from to Needs Triage.
He7d3r updated the task description. (Show Details)
He7d3r added a project: StructuredDiscussions.
He7d3r added a subscriber: He7d3r.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptApr 22 2015, 8:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Mattflaschen-WMF triaged this task as High priority.Apr 22 2015, 9:07 PM

This might have been suppressed, but if so it's still not supposed to render like that.

Mattflaschen-WMF raised the priority of this task from High to Unbreak Now!.Apr 23 2015, 2:18 AM
DannyH updated the task description. (Show Details)Apr 23 2015, 5:46 PM
DannyH set Security to None.
DannyH added a subscriber: DannyH.

That's a topic where I tested out suppression & restoring last week -- maybe it didn't do the restoration correctly?

Just tested this.

This is the history page of a suppressed topic, as seen by anon user (or someone who doesn't have the right permissions).

After restore (seen by the anon user again):

  • the topic is NOT on the Flow board
  • the topic IS in the TOC of the Flow board (probably causing T96933)
  • the permalink page is still empty
  • the history page still shows the 2 undefined

Change 207854 had a related patch set uploaded (by Mattflaschen):
Check for history permission later rather than sooner

https://gerrit.wikimedia.org/r/207854

Change 207854 abandoned by Sbisson:
Check for history permission later rather than sooner

Reason:
Bundled in https://gerrit.wikimedia.org/r/#/c/207797/

https://gerrit.wikimedia.org/r/207854