Page MenuHomePhabricator
Create Task
Maniphest T97010

MMV not working for pages after saved with VisualEditor and not reloaded
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

  1. Open a page with an image
  2. Click "Edit" (to start VE)
  3. Change the content
  4. Save the page
  5. Click the image

Expected:
The image should be opened with MMV

Observed:
You will be redirected to the File page

If you reload the page, you can open the image with MMV. Reproduced on https://www.mediawiki.org/wiki/Project:Sandbox

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MultimediaViewermaster+9 -5Use wikipage.content hook for updating thumbnail list
mediawiki/extensions/MultimediaViewermaster+7 -1Re-add event listeners to images after a finished VE edit
Customize query in gerrit

Related Objects

Event Timeline

Florian created this task.Apr 23 2015, 8:53 AM
Florian raised the priority of this task from to Needs Triage.
Florian updated the task description. (Show Details)
Florian added projects: VisualEditor, MediaViewer.
Florian added a subscriber: Florian.
Restricted Application added a project: Multimedia. · View Herald TranscriptApr 23 2015, 8:53 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Florian claimed this task.Aug 12 2015, 6:52 PM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptAug 12 2015, 6:52 PM
gerritbot added a subscriber: gerritbot.Aug 12 2015, 7:04 PM

Change 231079 had a related patch set uploaded (by Florianschmidtwelzow):
Re-add event listeners to images after a finished VE edit

https://gerrit.wikimedia.org/r/231079

gerritbot added a project: Patch-For-Review.Aug 12 2015, 7:04 PM
Jdforrester-WMF triaged this task as Medium priority.Aug 12 2015, 7:07 PM
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
• Tgr merged a task: T101951: MediaViewer does not work directly after saving a VisualEditor edit.Aug 12 2015, 10:20 PM
• Tgr added subscribers: Mooeypoo, Krenair, • Tgr and 2 others.
gerritbot added a comment.Aug 14 2015, 12:42 AM

Change 231079 merged by jenkins-bot:
Re-add event listeners to images after a finished VE edit

https://gerrit.wikimedia.org/r/231079

Diffusion mentioned this in rMEXT814485abbc58: Updated mediawiki/extensions Project: mediawiki/extensions/MultimediaViewer….Aug 14 2015, 12:43 AM
• Tgr mentioned this in rEMMV7b50d14a8e76: Re-add event listeners to images after a finished VE edit.Aug 14 2015, 12:43 AM
Florian closed this task as Resolved.Aug 14 2015, 12:44 AM

\o/ Thanks @Tgr

Forrestbot added a project: WMF-deploy-2015-08-18_(1.26wmf19).Aug 14 2015, 1:00 AM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Aug 17 2015, 5:31 PM
Jdforrester-WMF removed a project: Patch-For-Review.Aug 18 2015, 7:00 PM
gerritbot added a comment.Sep 1 2015, 2:49 AM

Change 235176 had a related patch set uploaded (by Gergő Tisza):
Use wikipage.content hook for updating thumbnail list

https://gerrit.wikimedia.org/r/235176

gerritbot added a project: Patch-For-Review.Sep 1 2015, 2:49 AM
gerritbot added a comment.Sep 1 2015, 1:54 PM

Change 235176 merged by jenkins-bot:
Use wikipage.content hook for updating thumbnail list

https://gerrit.wikimedia.org/r/235176

• Tgr mentioned this in rMEXT7ae25e4a7b57: Updated mediawiki/extensions Project: mediawiki/extensions/MultimediaViewer….Sep 1 2015, 1:54 PM
• Tgr mentioned this in rEMMV2e6ffeff9625: Use wikipage.content hook for updating thumbnail list.Sep 1 2015, 1:58 PM
Jdforrester-WMF removed a project: Patch-For-Review.Sep 1 2015, 10:53 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL