Page MenuHomePhabricator

Collection extension should log source of OCG requests
Open, MediumPublic

Description

Extension:Collection lets you make custom collections for rendering, as well as rendering "saved books" or "just one article".

Both of the latter have corresponding URLs that I would like to log, so that we can easily see the source of a buggy request or DoS.

Because of the way the extension is written, we've lost the source information by the time we invoke OCG. We should preserve the 'source URL' in the extension, where such a thing makes sense, and then pass it to OCG so that it can use it in its logs.

Details

Related Gerrit Patches:
mediawiki/extensions/Collection : masterPass request source and user information to backend.
mediawiki/extensions/Collection/OfflineContentGenerator : masterLog request source information passed along from PHP.

Event Timeline

cscott created this task.Apr 23 2015, 2:37 PM
cscott claimed this task.
cscott raised the priority of this task from to Medium.
cscott updated the task description. (Show Details)
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 23 2015, 2:37 PM

Change 314177 had a related patch set uploaded (by C. Scott Ananian):
Log request source information passed along from PHP.

https://gerrit.wikimedia.org/r/314177

Change 314178 had a related patch set uploaded (by C. Scott Ananian):
Pass request source and user information to backend.

https://gerrit.wikimedia.org/r/314178

Change 314177 merged by jenkins-bot:
Log request source information passed along from PHP.

https://gerrit.wikimedia.org/r/314177

As already announced in Tech News, OfflineContentGenerator (OCG) will not be used anymore after October 1st, 2017 on Wikimedia sites. OCG will be replaced by Electron. You can read more on mediawiki.org.