Page MenuHomePhabricator

Collection extension should log source of OCG requests
Open, MediumPublic

Description

Extension:Collection lets you make custom collections for rendering, as well as rendering "saved books" or "just one article".

Both of the latter have corresponding URLs that I would like to log, so that we can easily see the source of a buggy request or DoS.

Because of the way the extension is written, we've lost the source information by the time we invoke OCG. We should preserve the 'source URL' in the extension, where such a thing makes sense, and then pass it to OCG so that it can use it in its logs.

Event Timeline

cscott created this task.Apr 23 2015, 2:37 PM
cscott claimed this task.
cscott raised the priority of this task from to Medium.
cscott updated the task description. (Show Details)
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 23 2015, 2:37 PM

Change 314177 had a related patch set uploaded (by C. Scott Ananian):
Log request source information passed along from PHP.

https://gerrit.wikimedia.org/r/314177

Change 314178 had a related patch set uploaded (by C. Scott Ananian):
Pass request source and user information to backend.

https://gerrit.wikimedia.org/r/314178

Change 314177 merged by jenkins-bot:
Log request source information passed along from PHP.

https://gerrit.wikimedia.org/r/314177

As already announced in Tech News, OfflineContentGenerator (OCG) will not be used anymore after October 1st, 2017 on Wikimedia sites. OCG will be replaced by Electron. You can read more on mediawiki.org.

@cscott: Hi! This task has been assigned to you a while ago. Could you share an update? Do you still plan to work on this task? Or is this declined nowadays because we do not use OCG anymore? You can change the task status via the Add Action...Change Status dropdown. Thanks.

Aklapper removed cscott as the assignee of this task.Jun 19 2020, 4:25 PM
Aklapper added a subscriber: cscott.

This task has been assigned to the same task owner for more than two years. Resetting task assignee due to inactivity, to decrease task cookie-licking and to get a slightly more realistic overview of plans. Please feel free to assign this task to yourself again if you still realistically work or plan to work on this task - it would be welcome!

For tips how to manage individual work in Phabricator (noisy notifications, lists of task, etc.), see https://phabricator.wikimedia.org/T228575#6237124 for available options.
(For the records, two emails were sent to assignee addresses before resetting assignees. See T228575 for more info and for potential feedback. Thanks!)