Handle RESTbase load failures more gracefully with a message to the user explaining "the editing server didn't respond" or similar
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Jdforrester-WMF
	Apr 23 2015, 4:39 PM

Description

Showing an error message, at least, would be a start.

Details

	Subject	Repo	Branch	Lines +/-
	ve.init.mw.TargetLoader: Error when RESTbase load call fails	mediawiki/extensions/VisualEditor	master	+11 -1

Customize query in gerrit

Related Objects

Mentioned In: rEVED7653dec439c4: ve.init.mw.TargetLoader: Error when RESTbase load call fails
T104376: VisualEditor not loading at all - mw.libs.ve.targetLoader.requestPageData/restbasePromise

Event Timeline

Jdforrester-WMF created this task.Apr 23 2015, 4:39 PM

Jdforrester-WMF raised the priority of this task from to High.

Jdforrester-WMF updated the task description. (Show Details)

Jdforrester-WMF added projects: VisualEditor-MediaWiki, VisualEditor, VisualEditor 2014/15 Q4 blockers.

Jdforrester-WMF subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 23 2015, 4:39 PM

What sort of failures are we missing this on? We do show error messages when we have issues fetching data from the server.

Jdforrester-WMF moved this task from Nominated to Backlog: Urgent Fixes on the VisualEditor 2014/15 Q4 blockers board.May 6 2015, 6:08 PM

In T97041#1254766, @Krenair wrote:

What sort of failures are we missing this on? We do show error messages when we have issues fetching data from the server.

https://gerrit.wikimedia.org/r/#/c/208507/ fixed it so failed RESTbase loads return the user to read mode (without comment), but really we should use the same "We couldn't load stuff from Parsoid" error message that we use when loading via that path.

Jdforrester-WMF set Security to None.May 6 2015, 9:53 PM

Jdforrester-WMF edited a custom field.

Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.May 8 2015, 1:43 AM

Jdforrester-WMF moved this task from Backlog: Urgent Fixes to Backlog on the VisualEditor 2014/15 Q4 blockers board.May 21 2015, 2:18 PM

Jdforrester-WMF renamed this task from Handle load failures more gracefully to Handle RESTbase load failures more gracefully with a message to the user explaining "the editing server didn't respond" or similar.Jun 16 2015, 10:08 PM

Jdforrester-WMF moved this task from TR6: Visual diffs to TR1: Releases on the VisualEditor board.Jun 18 2015, 12:16 AM

Seems simple enough

Change 221748 had a related patch set uploaded (by Alex Monk):
Error when restbase call fails

https://gerrit.wikimedia.org/r/221748

gerritbot added a project: Patch-For-Review.Jun 29 2015, 8:14 PM

Jdforrester-WMF moved this task from Backlog to Doing on the VisualEditor 2014/15 Q4 blockers board.Jun 29 2015, 8:42 PM

Krenair mentioned this in T104376: VisualEditor not loading at all - mw.libs.ve.targetLoader.requestPageData/restbasePromise.Jun 30 2015, 7:32 PM

Jdforrester-WMF added a project: VisualEditor 2015/16 Q1 blockers.Jul 1 2015, 3:52 PM

Jdforrester-WMF moved this task from Nominated to Doing on the VisualEditor 2015/16 Q1 blockers board.

Jdforrester-WMF removed a project: VisualEditor 2014/15 Q4 blockers.Jul 1 2015, 3:54 PM

Krenair merged a task: T106202: VisualEditor should more gracefully handle restbase returning a 500 status code.Jul 18 2015, 5:17 AM

Krenair added a subscriber: Legoktm.