Maniphest T97076

Visiting a collection triggers an API request on every page load
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Apr 23 2015, 7:31 PM

Tags

Referenced Files

None

Subscribers

Description

When I visit http://localhost:8888/w/index.php/Special:Gather/by/Jdlrobson/89 ext.gather.special/init.js fires an API request. This shouldn't happen. It also make some bad assumptions about the URL - I'm seeing API requests to 'http://localhost:8888/w/api.php?action=query&format=json&list=lists&lstids=index%2Ephp&lstprop=label%7Cdescription%7Cpublic%7Cimage%7Ccount%7Cowner'

Details

	Subject	Repo	Branch	Lines +/-
	Fix flag button, stop unnecessary API request	mediawiki/extensions/Gather	master	+21 -25

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Declined		None	T94641 Allow autopatrolled users to contribute in list moderation.
		Resolved		Jdlrobson	T94228 Add a hide button to collections
		Resolved		• rmoen	T94871 Add a flag button
		Resolved		Jdlrobson	T97076 Visiting a collection triggers an API request on every page load

Event Timeline

Jdlrobson created this task.Apr 23 2015, 7:31 PM

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Gather Sprint Forward.

Jdlrobson moved this task to In Analysis on the Gather Sprint Forward board.

Jdlrobson subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 23 2015, 7:31 PM

Jdlrobson claimed this task.Apr 23 2015, 7:31 PM

Jdlrobson added a parent task: T94871: Add a flag button.

Jdlrobson moved this task from In Analysis to In development on the Gather Sprint Forward board.

Jdlrobson triaged this task as High priority.Apr 23 2015, 7:40 PM

Jdlrobson moved this task from In development to Code review needed on the Gather Sprint Forward board.

Change 206168 had a related patch set uploaded (by Jdlrobson):
Fix flag button, stop unnecessary API request

https://gerrit.wikimedia.org/r/206168

gerritbot added a project: Patch-For-Review.Apr 23 2015, 10:49 PM

• rmoen moved this task from Code review needed to Ready for signoff on the Gather Sprint Forward board.Apr 23 2015, 10:53 PM

Change 206168 merged by jenkins-bot:
Fix flag button, stop unnecessary API request

https://gerrit.wikimedia.org/r/206168

Diffusion mentioned this in rMEXT30b1d877f1dc: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….Apr 23 2015, 11:01 PM

Jdlrobson mentioned this in rEGAT9205cd1c700b: Fix flag button, stop unnecessary API request.Apr 23 2015, 11:01 PM

Jdlrobson closed this task as Resolved.Apr 23 2015, 11:01 PM

• JKatzWMF moved this task from Ready for signoff to Done on the Gather Sprint Forward board.Apr 27 2015, 4:15 AM