Maniphest T97085

Overlays do not work correctly on non-Minerva skins
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	Jdlrobson
	Apr 23 2015, 9:26 PM

Tags

Referenced Files

None

Subscribers

Description

If I try to use the Overlay view on desktop Vector it is styled incorrectly. Styles are missing, the page remains scrollable.
We should look at what OO.UI.Dialogs do and mimic their styles in the interim whilst we refactor Overlay.js as an OO.UI element.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Declined		None	T94233 [EPIC] Promote Gather to stable
		Declined		Jdlrobson	T95227 [EPIC] Expose Gather as desktop beta feature
		Declined		None	T94063 Edit and delete buttons are currently broken on desktop skins
		Declined		None	T97085 Overlays do not work correctly on non-Minerva skins

Event Timeline

Jdlrobson created this task.Apr 23 2015, 9:26 PM

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Web-Team-Backlog.

Jdlrobson moved this task to Triaged but Future on the Web-Team-Backlog board.

Jdlrobson subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 23 2015, 9:26 PM

Jdlrobson added a parent task: T95227: [EPIC] Expose Gather as desktop beta feature.Apr 23 2015, 9:27 PM

Jdlrobson added a parent task: T94063: Edit and delete buttons are currently broken on desktop skins.

Jdlrobson merged a task: T98184: Overlays do not work in non-Minerva skins.Aug 14 2015, 10:49 PM

Jdlrobson added subscribers: gerritbot, • Moushira, • JKatzWMF, Jalexander.

Jdlrobson triaged this task as Medium priority.Sep 16 2015, 6:23 PM

Jdlrobson edited projects, added MobileFrontend; removed Web-Team-Backlog.Sep 18 2015, 8:37 PM

Jdlrobson set Security to None.

Jdlrobson moved this task from Backlog to Team:Growth on the MobileFrontend board.Nov 4 2015, 5:04 PM

Jdlrobson moved this task from Team:Growth to team:other on the MobileFrontend board.Feb 18 2016, 6:43 PM

MBinder_WMF added a project: Web-Team-Backlog.Apr 27 2016, 4:19 PM

• Jhernandez moved this task from Triaged but Future to Incoming on the Web-Team-Backlog board.Apr 27 2016, 4:36 PM

When building things for desktop we should strive to use OO.UI.Dialog.