Page MenuHomePhabricator
Create Task
Maniphest T97094

FontChanger should use Button to construct its buttons
Closed, ResolvedPublic
Actions

Description

The font changer hardcodes classes for mw-ui-button
If we use this abstraction it will make it easier for us to port to OOjs UI
See https://gerrit.wikimedia.org/r/#/c/206016/3 for guidance.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileFrontendmaster+28 -3Use Button to create buttons
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Apr 23 2015, 11:59 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Readers-Web-Backlog.
Jdlrobson moved this task to Triaged but Future on the Readers-Web-Backlog board.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 23 2015, 11:59 PM
Florian claimed this task.Aug 8 2015, 11:13 AM
gerritbot added a subscriber: gerritbot.Aug 8 2015, 11:22 AM

Change 230299 had a related patch set uploaded (by Florianschmidtwelzow):
Use Button to create buttons

https://gerrit.wikimedia.org/r/230299

gerritbot added a project: Patch-For-Review.Aug 8 2015, 11:22 AM
gerritbot added a comment.Aug 11 2015, 11:36 PM

Change 230299 merged by jenkins-bot:
Use Button to create buttons

https://gerrit.wikimedia.org/r/230299

Florian mentioned this in rEMFR3ba59cfac1f0: Use Button to create buttons.Aug 11 2015, 11:36 PM
Diffusion mentioned this in rMEXT989730fd480c: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Aug 11 2015, 11:36 PM
Forrestbot added a project: WMF-deploy-2015-08-18_(1.26wmf19).Aug 12 2015, 12:00 AM
Jdlrobson closed this task as Resolved.Aug 12 2015, 12:19 AM
• Phabricator_maintenance moved this task from Triaged but Future to 2015-16 Q1 on the Readers-Web-Backlog board.Mar 7 2018, 1:11 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL