Page MenuHomePhabricator

Fine tune "Code Review overview" metrics page in Korma
Closed, ResolvedPublic

Description

Let's fine tune http://korma.wmflabs.org/browser/scr.html until we are happy about it. As far as we know, this is a stock page in Metrics Grimoire's dashboard.

http://korma.wmflabs.org/browser/scr.html is quite mysterious for me, I'm unable to extract any meaningful information from it.

  • "pending" graph has no legend, the ? icon does nothing. Worth noting if you're filtering any repo, or -1/-2 commits, or not.

Proposing to change this graph for "Backlog of open changesets (monthly snapshots)" from http://korma.wmflabs.org/browser/gerrit_review_queue.html

  • "Review time in days": absolutely no idea what this is. The legend is just a tautology so it doesn't explain anything: "Review time in days: Median review time in days".

Gone.

  • "submitted vs. Merged changes vs. Abandoned": this is the only clear part of the page. :)

:)

  • "code reviews waiting for reviewer" doesn't make any sense, a code review (which is composed by comments and a label like +1, +2) always as an author. Perhaps this means "commits waiting for reviews", but from the examples below I can't tell.
  • "code reviews waiting for submitter" presumably means "commits waiting for merge" ("submit" is ambiguous, better not use it). Note that merge depends on +2 which is one code review label. If that's the meaning,

Agreed, we need to see what these labels and values actually mean.

  • "Top Successful submitters" per above, confusing: do you mean commit authors, or commit mergers/approvers/+2'er?

Gone.

Note that self-merges have not been excluded yet, but they're in the process of being filtered at last according to bug 37463 comment 30.

Resolved.

Event Timeline

Qgil claimed this task.
Qgil raised the priority of this task from to Medium.
Qgil updated the task description. (Show Details)
Qgil added subscribers: Qgil, Nemo_bis.

I'm taking this task to define with Bitergia what needs to be done.

Qgil raised the priority of this task from Medium to High.Jun 11 2015, 8:21 AM

I think the best solution here is to bring the generic graphs from http://korma.wmflabs.org/browser/gerrit_review_queue.html, which have received a lot more work on words and definitions.

http://korma.wmflabs.org/browser/scr.html could contain all the general graphs and the tables of contributors. "pending" can be substituted by "Backlog of open changesets (monthly snapshots)".

http://korma.wmflabs.org/browser/gerrit_review_queue.html could keep only the ranking of repositories.

A single sentence at the top of the page would refer to the other page, helping users to find the data.

I agree that this is confusing, not just because of the labels, also because of the data. It needs clarification:

80	code reviews waiting for reviewer	162	code reviews waiting for submitter

Other confusing labels listed in the description have gone away. I will remove them from the description for clarity.

Qgil removed Qgil as the assignee of this task.Jun 25 2015, 8:21 AM
Qgil updated the task description. (Show Details)
Qgil set Security to None.
Qgil added a subscriber: Dicortazar.
Qgil lowered the priority of this task from High to Medium.Jun 25 2015, 8:29 AM

This task was part of the June sprint but then slipped off the July sprint. Proposing it for August.

I agree that this is confusing, not just because of the labels, also because of the data. It needs clarification:

80 code reviews waiting for reviewer 162 code reviews waiting for submitter

These are upstream strings hence I created https://github.com/Bitergia/grimoire-dashboard/issues/1 - once the strings are clearer we can look at the data (preferably in a separate ticket). Same for data in "median time to review in days".

bring the generic graphs from gerrit_review_queue.html. scr.html could contain all the general graphs and the tables of contributors. "pending" can be substituted by "Backlog of open changesets (monthly snapshots)".

Yes. Comparing both graphs, "Pending reviews" and "New changesets" are extremely similar lines over the last two years.

gerrit_review_queue.html could keep only the ranking of repositories. A single sentence at the top of the page would refer to the other page

Quick attempt in https://github.com/Bitergia/mediawiki-dashboard/pull/60/files

These are upstream strings hence I created https://github.com/Bitergia/grimoire-dashboard/issues/1

Upstream comments were reasonable enough that I closed that ticket (hard to find a better word than "Code Review" for the entire process)... @Nemo_bis (as you brought this up originally): If you have better ideas how to rephrase, please join the conversation in the upstream ticket. Thanks.

I already gave a better proposal above.

For example, when a code review process starts, by submission of a proposed change, in a sense the process is "waiting for reviewer"

No, it's waiting for a review. Reviewers may already be provided (e.g. cc'd). Hence I proposed/guessed "commits waiting for reviews" ("commits" can be replaced by "patch", "code" or whatever generic term the dashboard desires to use consistently across the board).

@Nemo_bis: It requires a better word than "Code Review". See and join the conversation in the upstream ticket. Thanks.

My proposal doesn't use the word "code review".

Yeah. But your proposal cannot be used in other concatenated strings. See the upstream ticket, discuss in the upstream ticket. Thanks.

@Aklapper not sure about the impact of this changes, I mean, everything work but makes a bit difficult the maintenance of newer versions of the product. In any case, we're starting the dash from scratch so I guess we can live with this for the following months. We hope to have a newer version by FOSDEM/OSCON

What do you think @Dicortazar?

Merged. Thanks!
I'm going to close this task once it's live on korma.

This is deployed now and live on korma.
Closing as resolved.