Page MenuHomePhabricator

Flow inputs' placeholders should be bidi-isolated when viewed with interface directionality that is different than the wiki directionality
Open, MediumPublic2 Estimated Story Points

Description

The inputs in a Flow board have messages that appear in the interface directionality; which means that if we look at the Hebrew Wikipedia with English interface, the bottom input would say, in English "Reply to: '... topic name...'".

However, those inputs are RTL aligned, which, especially if the topic is (or contains) English words, results in breaking the quotation marks, like this:

reply-to-bidi.png (83×867 px, 5 KB)

(The above is in a Hebrew Wiki but viewed with English interface)

This can be fixed by wrapping the placeholder with RLM/LRM entities. We can't do this in CSS because we don't want to override the input's 'direction' CSS property (The direction should still be RTL because the content is RTL) but the placeholder message itself should be isolated.

Event Timeline

Mooeypoo claimed this task.
Mooeypoo raised the priority of this task from to Needs Triage.
Mooeypoo updated the task description. (Show Details)
Mooeypoo subscribed.
Mooeypoo triaged this task as Medium priority.Apr 24 2015, 11:47 PM
Mooeypoo set Security to None.

@Mooeypoo if this issue should not be solved by CSS directionality property can you specify what RLM/LRM entities are?

Those don't work well in placeholders, unfortunately.

There may be things we can do with pseudo-placeholders, but it's far from straight forward, and may have some support issues. We're painfully aware of this problem, but fixing it is, sadly, not as straight forward as we'd like, and may require some creative thinking on this.

This, btw, should be a general thing we should solve to all products, in or out of Flow, seeing as inputs are basically everywhere.