Page MenuHomePhabricator

Fix all .erb variable warnings
Closed, ResolvedPublic

Description

Puppet master logging is pretty noise, in large part due to things like

Variable access via 'config_file' is deprecated. Use '@config_file' instead.

It should be simple enough to update all those.

Details

SubjectRepoBranchLines +/-
operations/puppetproduction+1 -1
operations/puppetproduction+3 -3
operations/puppetproduction+1 -1
operations/puppetproduction+7 -7
operations/puppet/zookeepermaster+2 -2
operations/puppetproduction+1 -1
operations/puppetproduction+1 -1
operations/puppetproduction+2 -2
operations/puppetproduction+2 -2
operations/puppetproduction+1 -1
operations/puppetproduction+2 -2
operations/puppetproduction+1 -1
operations/puppetproduction+1 -1
operations/puppetproduction+2 -2
operations/puppetproduction+37 -37
operations/puppetproduction+1 -1
operations/puppetproduction+2 -2
operations/puppetproduction+2 -2
operations/puppetproduction+1 -1
operations/puppetproduction+2 -2
operations/puppetproduction+4 -4
operations/puppetproduction+15 -15
operations/puppetproduction+7 -7
operations/puppetproduction+1 -1
operations/puppetproduction+1 -1
operations/puppetproduction+2 -2
operations/puppetproduction+13 -13
operations/puppetproduction+12 -12
operations/puppetproduction+9 -9
operations/puppetproduction+5 -5
Show related patches Customize query in gerrit

Related Objects

Mentioned In
rOPZK6e3a24b08327: Qualify @jmx_port in zookeeper.default.erb
rOPUP25c1ee3a8114: rra_sizes: qualify var
rOPUP997a1f2baa5f: ssl: qualify var
rOPUP7f0832074876: wikitech apache: qualify realm var
rOPUPed052719bedf: Qualify erb template variables
rOPUP2164101633dd: webserver,generic_vhost: qualify title var
rOPUPa6d96362a199: varnish_instances: qualify var
rOPUP6f701db783dc: ganglia: qualify var
rOPUP3214ec409dbf: graphite: hostname is a fact, qualify in the right scope
rOPUP34ebabb9ab5c: multicast: qualify var
rOPUP8f99c80ae984: puppet_certname: qualify var
rOPUP59a7e8cbaba6: remote_cert_cleaner: qualify var
rOPUP6dc08fa5825f: site: qualify var
rOPUPf473363e7db5: salt_reactor_options: qualify var
rOPUP6add92c3241d: novaconfig: qualify var
rOPUPd959c8b6393a: zookeeper_hosts: qualify var
rOPUP8b062f09e226: Revert "graphite: hotname is a fact, qualify"
rOPUP3faba9b9b4ec: strongswan: qualify var
rOPUP5cc8b0e73a52: memorysize is a fact, qualify
rOPUP51e0469b94bf: ldap-groups: qualify var
rOPUPb321d76c20da: keystongconfig: qualify var
rOPUP7e75f5a71112: nove: qualify vars
rOPUPee43ebe9fe92: ganalia_new: qualify var
rOPUPca0957e0eeec: graphite: hotname is a fact, qualify
rOPUPc2c3cc128efa: glance: qualify var
rOPUP51f172fcc432: ganglia: qualify var
rOPUP35d9c33e5471: openstack : qualify designateconfig
rOPUPce75d29871c8: glance: qualify vars
rOPUPc604caac0b8d: glance: qualify vars
rOPUPdcac665ef8c2: strongswan: fqdn is a fact, qualify
rOPUPc22f386f5f42: @qualify some .erb variable references.
rOPUP9bb5dad70416: @qualify a local .erb variable
rOPUPccd791f46d64: Use @certname instead of certname in .erb
rOPUP65fce564acb5: Use @resolver instead of resolver.
Mentioned Here
P808 puppetDeprecated
P741 Puppet variable access errors, 8-Jun-2015
P714 Puppet variable access warnings

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 215680 merged by Andrew Bogott:
openstack : qualify designateconfig

https://gerrit.wikimedia.org/r/215680

Change 215700 had a related patch set uploaded (by Matanya):
graphite: hotname is a fact, qualify

https://gerrit.wikimedia.org/r/215700

Change 215695 merged by Andrew Bogott:
ganglia: qualify var

https://gerrit.wikimedia.org/r/215695

Change 215694 merged by Andrew Bogott:
glance: qualify var

https://gerrit.wikimedia.org/r/215694

Change 215704 had a related patch set uploaded (by Matanya):
strongswan: qualify var

https://gerrit.wikimedia.org/r/215704

Change 215700 merged by Andrew Bogott:
graphite: hotname is a fact, qualify

https://gerrit.wikimedia.org/r/215700

Change 215705 had a related patch set uploaded (by Matanya):
nove: qualify vars

https://gerrit.wikimedia.org/r/215705

Change 215707 had a related patch set uploaded (by Matanya):
ganalia_new: qualify var

https://gerrit.wikimedia.org/r/215707

Change 215709 had a related patch set uploaded (by Matanya):
keystongconfig: qualify var

https://gerrit.wikimedia.org/r/215709

Change 215707 merged by Andrew Bogott:
ganalia_new: qualify var

https://gerrit.wikimedia.org/r/215707

Change 215705 merged by Andrew Bogott:
nove: qualify vars

https://gerrit.wikimedia.org/r/215705

Change 215712 had a related patch set uploaded (by Matanya):
ldap-groups: qualify var

https://gerrit.wikimedia.org/r/215712

Change 215709 merged by Andrew Bogott:
keystongconfig: qualify var

https://gerrit.wikimedia.org/r/215709

Change 215763 had a related patch set uploaded (by Matanya):
memorysize is a fact, qualify

https://gerrit.wikimedia.org/r/215763

Change 215712 merged by Andrew Bogott:
ldap-groups: qualify var

https://gerrit.wikimedia.org/r/215712

Change 215767 had a related patch set uploaded (by Matanya):
multicast: qualify var

https://gerrit.wikimedia.org/r/215767

Change 215763 merged by Andrew Bogott:
memorysize is a fact, qualify

https://gerrit.wikimedia.org/r/215763

Change 215769 had a related patch set uploaded (by Matanya):
novaconfig: qualify var

https://gerrit.wikimedia.org/r/215769

Change 215772 had a related patch set uploaded (by Matanya):
puppet_certname: qualify var

https://gerrit.wikimedia.org/r/215772

Change 215776 had a related patch set uploaded (by Matanya):
realm: qualify var

https://gerrit.wikimedia.org/r/215776

Change 215777 had a related patch set uploaded (by Matanya):
remote_cert_cleaner: qualify var

https://gerrit.wikimedia.org/r/215777

Change 215784 had a related patch set uploaded (by Matanya):
rra_sizes: qualify var

https://gerrit.wikimedia.org/r/215784

Change 215785 had a related patch set uploaded (by Matanya):
salt_reactor_options: qualify var

https://gerrit.wikimedia.org/r/215785

Change 215788 had a related patch set uploaded (by Matanya):
site: qualify var

https://gerrit.wikimedia.org/r/215788

Change 215792 had a related patch set uploaded (by Matanya):
ssl: qualify var

https://gerrit.wikimedia.org/r/215792

Change 215793 had a related patch set uploaded (by Matanya):
title: qualify var

https://gerrit.wikimedia.org/r/215793

Change 215794 had a related patch set uploaded (by Matanya):
varnish_instances: qualify var

https://gerrit.wikimedia.org/r/215794

Change 215795 had a related patch set uploaded (by Matanya):
zookeeper_hosts: qualify var

https://gerrit.wikimedia.org/r/215795

Change 215814 had a related patch set uploaded (by Filippo Giunchedi):
Revert "graphite: hotname is a fact, qualify"

https://gerrit.wikimedia.org/r/215814

Change 215814 merged by Filippo Giunchedi:
Revert "graphite: hotname is a fact, qualify"

https://gerrit.wikimedia.org/r/215814

a word of caution before plowing through all the variables, hostname _will_ change if qualified, e.g.

-exec /usr/bin/carbon-c-relay -H graphite1001_local -p 1903 -f /etc/carbon/local-relay.conf
+exec /usr/bin/carbon-c-relay -H graphite.wikimedia.org_local -p 1903 -f /etc/carbon/local-relay.conf

Change 215795 merged by Ottomata:
zookeeper_hosts: qualify var

https://gerrit.wikimedia.org/r/215795

Change 215769 merged by Andrew Bogott:
novaconfig: qualify var

https://gerrit.wikimedia.org/r/215769

Change 215785 merged by Andrew Bogott:
salt_reactor_options: qualify var

https://gerrit.wikimedia.org/r/215785

Change 215788 merged by Andrew Bogott:
site: qualify var

https://gerrit.wikimedia.org/r/215788

Change 215777 merged by Andrew Bogott:
remote_cert_cleaner: qualify var

https://gerrit.wikimedia.org/r/215777

Change 215772 merged by Gage:
puppet_certname: qualify var

https://gerrit.wikimedia.org/r/215772

Update:

1Variable access via 'data_dir' is deprecated. Use '@data_dir' instead. template[/etc/puppet/modules/zookeeper/templates/zoo.cfg.erb]:22
2Variable access via 'data_sources' is deprecated. Use '@data_sources' instead. template[/etc/puppet/templates/ganglia/gmetad.conf.erb]:44
3Variable access via 'data_sources' is deprecated. Use '@data_sources' instead. template[/etc/puppet/templates/ganglia/gmetad.conf.erb]:45
4Variable access via 'ganglia_group_name' is deprecated. Use '@ganglia_group_name' instead. template[/etc/puppet/modules/jmxtrans/templates/jmxtrans.json.erb]:61
5Variable access via 'hostname' is deprecated. Use '@hostname' instead. template[/etc/puppet/modules/graphite/templates/initscripts/frontend-relay.upstart.erb]:15
6Variable access via 'hostname' is deprecated. Use '@hostname' instead. template[/etc/puppet/modules/graphite/templates/initscripts/local-relay.upstart.erb]:15
7Variable access via 'hosts' is deprecated. Use '@hosts' instead. template[/etc/puppet/modules/zookeeper/templates/zoo.cfg.erb]:12
8Variable access via 'jmx_port' is deprecated. Use '@jmx_port' instead. template[/etc/puppet/modules/zookeeper/templates/zookeeper.default.erb]:10
9Variable access via 'jmx_port' is deprecated. Use '@jmx_port' instead. template[/etc/puppet/modules/zookeeper/templates/zookeeper.default.erb]:8
10Variable access via 'log_directory' is deprecated. Use '@log_directory' instead. template[/etc/puppet/templates/udp2log/filters.erbium.erb]:19
11Variable access via 'log_directory' is deprecated. Use '@log_directory' instead. template[/etc/puppet/templates/udp2log/filters.erbium.erb]:24
12Variable access via 'log_directory' is deprecated. Use '@log_directory' instead. template[/etc/puppet/templates/udp2log/filters.misc.erb]:6
13Variable access via 'log_directory' is deprecated. Use '@log_directory' instead. template[/etc/puppet/templates/udp2log/filters.mw.erb]:1
14Variable access via 'multicast' is deprecated. Use '@multicast' instead. template[/etc/puppet/templates/udp2log/udp2log.init.erb]:26
15Variable access via 'packet_loss_log' is deprecated. Use '@packet_loss_log' instead. template[/etc/puppet/templates/udp2log/filters.erbium.erb]:6
16Variable access via 'realm' is deprecated. Use '@realm' instead. template[/etc/puppet/templates/apache/sites/wikitech.wikimedia.org.erb]:106
17Variable access via 'rra_sizes' is deprecated. Use '@rra_sizes' instead. template[/etc/puppet/templates/ganglia/gmetad.conf.erb]:59
18Variable access via 'ssl' is deprecated. Use '@ssl' instead. template[/etc/puppet/templates/apache/generic_vhost.erb]:3
19Variable access via 'ssl' is deprecated. Use '@ssl' instead. template[/etc/puppet/templates/apache/generic_vhost.erb]:40
20Variable access via 'ssl' is deprecated. Use '@ssl' instead. template[/etc/puppet/templates/apache/generic_vhost.erb]:52
21Variable access via 'title' is deprecated. Use '@title' instead. template[/etc/puppet/templates/apache/generic_vhost.erb]:48
22Variable access via 'varnish_instances' is deprecated. Use '@varnish_instances' instead. template[inline]:1
23Variable access via 'zookeeper_chroot' is deprecated. Use '@zookeeper_chroot' instead. template[inline]:1

Change 216624 had a related patch set uploaded (by Matanya):
ganglia: qualify var

https://gerrit.wikimedia.org/r/216624

I think i submitted patches for all of those which are not analytics-related. @Ottomata can you please fix yours, or catch me on IRC to work it out together?

Thanks for that, I was referring to the ones I didn't prepare a patch for, e.g zookeeper (and other submodules)

Change 216867 had a related patch set uploaded (by Matanya):
graphite: hotname is a fact, qualify in the right scope

https://gerrit.wikimedia.org/r/216867

Change 215767 merged by Ottomata:
multicast: qualify var

https://gerrit.wikimedia.org/r/215767

Change 216867 merged by Filippo Giunchedi:
graphite: hostname is a fact, qualify in the right scope

https://gerrit.wikimedia.org/r/216867

Change 216624 merged by Ottomata:
ganglia: qualify var

https://gerrit.wikimedia.org/r/216624

Change 215794 merged by BBlack:
varnish_instances: qualify var

https://gerrit.wikimedia.org/r/215794

Change 215793 merged by Dzahn:
webserver,generic_vhost: qualify title var

https://gerrit.wikimedia.org/r/215793

Change 219201 had a related patch set uploaded (by Ottomata):
Qualify @jmx_port in zookeeper.default.erb

https://gerrit.wikimedia.org/r/219201

Change 219201 merged by Ottomata:
Qualify @jmx_port in zookeeper.default.erb

https://gerrit.wikimedia.org/r/219201

Change 219202 had a related patch set uploaded (by Ottomata):
Qualify erb template variables

https://gerrit.wikimedia.org/r/219202

Change 219202 merged by Ottomata:
Qualify erb template variables

https://gerrit.wikimedia.org/r/219202

Change 215776 merged by Ottomata:
wikitech apache: qualify realm var

https://gerrit.wikimedia.org/r/215776

Change 215784 merged by Ottomata:
rra_sizes: qualify var

https://gerrit.wikimedia.org/r/215784

@Matanya, here's today's deprecation warnings

1Variable access via 'data_dir' is deprecated. Use '@data_dir' instead. template[/etc/puppet/modules/zookeeper/templates/zoo.cfg.erb]:22
2Variable access via 'ganglia_group_name' is deprecated. Use '@ganglia_group_name' instead. template[/etc/puppet/modules/jmxtrans/templates/jmxtrans.json.erb]:61
3Variable access via 'hosts' is deprecated. Use '@hosts' instead. template[/etc/puppet/modules/zookeeper/templates/zoo.cfg.erb]:12
4Variable access via 'jmx_port' is deprecated. Use '@jmx_port' instead. template[/etc/puppet/modules/zookeeper/templates/zookeeper.default.erb]:10
5Variable access via 'jmx_port' is deprecated. Use '@jmx_port' instead. template[/etc/puppet/modules/zookeeper/templates/zookeeper.default.erb]:8

Clement_Goubert claimed this task.
Clement_Goubert subscribed.

Being bold and closing this task since it's had no meaningful update in 7 years. Feel free to reopen if needed.