Puppet master logging is pretty noise, in large part due to things like
Variable access via 'config_file' is deprecated. Use '@config_file' instead.
It should be simple enough to update all those.
Puppet master logging is pretty noise, in large part due to things like
Variable access via 'config_file' is deprecated. Use '@config_file' instead.
It should be simple enough to update all those.
Change 215700 had a related patch set uploaded (by Matanya):
graphite: hotname is a fact, qualify
Change 215707 had a related patch set uploaded (by Matanya):
ganalia_new: qualify var
Change 215709 had a related patch set uploaded (by Matanya):
keystongconfig: qualify var
Change 215712 had a related patch set uploaded (by Matanya):
ldap-groups: qualify var
Change 215763 had a related patch set uploaded (by Matanya):
memorysize is a fact, qualify
Change 215772 had a related patch set uploaded (by Matanya):
puppet_certname: qualify var
Change 215777 had a related patch set uploaded (by Matanya):
remote_cert_cleaner: qualify var
Change 215785 had a related patch set uploaded (by Matanya):
salt_reactor_options: qualify var
Change 215794 had a related patch set uploaded (by Matanya):
varnish_instances: qualify var
Change 215795 had a related patch set uploaded (by Matanya):
zookeeper_hosts: qualify var
Change 215814 had a related patch set uploaded (by Filippo Giunchedi):
Revert "graphite: hotname is a fact, qualify"
Change 215814 merged by Filippo Giunchedi:
Revert "graphite: hotname is a fact, qualify"
a word of caution before plowing through all the variables, hostname _will_ change if qualified, e.g.
-exec /usr/bin/carbon-c-relay -H graphite1001_local -p 1903 -f /etc/carbon/local-relay.conf +exec /usr/bin/carbon-c-relay -H graphite.wikimedia.org_local -p 1903 -f /etc/carbon/local-relay.conf
I think i submitted patches for all of those which are not analytics-related. @Ottomata can you please fix yours, or catch me on IRC to work it out together?
Thanks for that, I was referring to the ones I didn't prepare a patch for, e.g zookeeper (and other submodules)
Change 216867 had a related patch set uploaded (by Matanya):
graphite: hotname is a fact, qualify in the right scope
Change 216867 merged by Filippo Giunchedi:
graphite: hostname is a fact, qualify in the right scope
Change 219201 had a related patch set uploaded (by Ottomata):
Qualify @jmx_port in zookeeper.default.erb
Change 219202 had a related patch set uploaded (by Ottomata):
Qualify erb template variables
Being bold and closing this task since it's had no meaningful update in 7 years. Feel free to reopen if needed.