Don't add empty parameters to citation in extension
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Josve05a
	Apr 26 2015, 9:52 PM

Description

Some citoid citations have empty strings, particularily in the author field. The extension should not add these as parameters.

To test, try adding:

http://foodcoop.com/go.php?id=101

In the extension.

https://en.wikipedia.org/w/index.php?title=User:Josve05a/sandbox&oldid=659359728

Citing adding empty parameters causes template errors.

Details

	Subject	Repo	Branch	Lines +/-
	Stop adding empty strings as params	mediawiki/extensions/Citoid	master	+275 -8

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T98902 Remove line feed characters in title (and possible other fields?)
		Resolved		Mvolz	T97259 Don't add empty parameters to citation in extension

Event Timeline

Josve05a created this task.Apr 26 2015, 9:52 PM

Josve05a raised the priority of this task from to Needs Triage.

Josve05a updated the task description. (Show Details)

Josve05a added a project: Citoid.

Josve05a subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2015, 9:52 PM

Josve05a moved this task from Backlog to Site specific issues on the Citoid board.Apr 26 2015, 9:53 PM

Josve05a renamed this task from Citing http://foodcoop.com/go.php?id=101 adds empty |last = causing red error. to Citing specific url's adds empty |last = causing red error..Apr 27 2015, 8:55 AM

Josve05a set Security to None.

Josve05a moved this task from Site specific issues to Backlog on the Citoid board.

Jdforrester-WMF moved this task from Backlog to Site specific issues on the Citoid board.Apr 27 2015, 8:23 PM

By default, we put author values that can't be split into two strings as the first element in the array; doing it the other way around could potentially fix this but while it might improve things for en it might worsen things for other languages; not sure exactly the right thing to do here.

Josve05a added a project: VisualEditor.May 4 2015, 10:50 PM

nshahquinn-wmf triaged this task as Medium priority.May 9 2015, 3:54 AM

Josve05a mentioned this in T99091: Citoid should not add website name (punknews.org) as a first name.May 14 2015, 4:44 PM

Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Jun 18 2015, 12:59 AM

Mvolz renamed this task from Citing specific url's adds empty |last = causing red error. to Don't add empty parameters to citation in extension.Jul 12 2015, 6:40 PM

Mvolz claimed this task.

Mvolz updated the task description. (Show Details)

Mvolz moved this task from Site specific issues to Service on the Citoid board.

Mvolz moved this task from Service to Extension on the Citoid board.Jul 13 2015, 9:08 AM

Change 224389 had a related patch set uploaded (by Mvolz):
Stop adding empty strings as params

https://gerrit.wikimedia.org/r/224389

gerritbot added a project: Patch-For-Review.Jul 13 2015, 9:23 AM

Mvolz updated the task description. (Show Details)Jul 13 2015, 9:35 AM

Mvolz updated the task description. (Show Details)

Mvolz added a parent task: T98902: Remove line feed characters in title (and possible other fields?).Jul 21 2015, 12:29 PM

Change 224389 merged by jenkins-bot:
Stop adding empty strings as params

https://gerrit.wikimedia.org/r/224389