Module user.groups styles should not be loaded on startup on all pages
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Apr 27 2015, 6:59 PM

Description

https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=user.groups&only=styles&skin=minerva&target=mobile&user=Jdlrobson&version=20150219T160030Z&*
None of the CSS in this module needs to be loaded on startup

Rules:
.mw-textarea-protected,.mw-textarea-protected + .ui-resizable .ace_content
div.templateeditor-show,p.templateeditor-show
span.templateeditor-show,small.templateeditor-show
table.templateeditor-show
li.templateeditor-show
div.autoconfirmed-show,p.autoconfirmed-show
span.autoconfirmed-show,small.autoconfirmed-show
table.autoconfirmed-show
li.autoconfirmed-show

Related Objects

Mentioned Here: rMW06ab9c0942f6: resourceloader: Merge 'user.groups' into 'user' module
T107399: Make top queue fully asynchronous

Event Timeline

Jdlrobson created this task.Apr 27 2015, 6:59 PM

Jdlrobson assigned this task to • Gilles.

Jdlrobson raised the priority of this task from to Medium.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added projects: Patch-For-Review, Performance-Team, Web-Team-Backlog, MobileFrontend.

Jdlrobson added subscribers: • bmansurov, Jdlrobson, gerritbot and 3 others.

Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Apr 27 2015, 7:10 PM

Jdlrobson removed a project: Patch-For-Review.Apr 28 2015, 11:13 PM

Jdlrobson set Security to None.

Jdlrobson removed • Gilles as the assignee of this task.May 1 2015, 12:26 AM

Jdlrobson edited projects, added MediaWiki-ResourceLoader; removed MobileFrontend.

Florian subscribed.May 7 2015, 3:42 PM

This should only happen for logged-in users. In which case it's quite likely that the css will apply to hidden content in headers, infoboxes and other visible interface elements shown for certain users. It'd be annoying to have that flash after the page loads.

Krinkle edited projects, added Performance Issue; removed Performance-Team.Jun 23 2015, 6:36 AM

Krinkle edited projects, added MediaWiki-User-Interface; removed MediaWiki-ResourceLoader.Jul 13 2015, 3:02 PM

Krinkle removed a subscriber: gerritbot.

Not related to ResourceLoader framework. Which and where modules are loaded is in OutputPage.

Making as Stalled. Per my previous comment, it may be undesirable to defer this module. It's hard to combine with other requests due to it depending on the current user group. The need to combine is is also very small because since the switch to HTTPS, our servers and users can now make full use of SPDY/HTTP2 which means combing two requests or having two requests alongside each other is effectively the same. So this gives us the best of both already.

Your right - this is only logged in users so probably not as big a concern as I first thought.

Jdlrobson removed a parent task: T97289: Trim down CSS loaded in the head for anonymous users on mobile.Aug 14 2015, 6:12 PM

Jdlrobson moved this task from Triaged but Future to 2015-16 Q4 on the Web-Team-Backlog board.Aug 14 2015, 10:50 PM

Jdlrobson removed a project: MediaWiki-User-Interface.Oct 1 2015, 5:31 PM

Jdlrobson edited projects, added MediaWiki-User-Interface, MediaWiki-extensions-General; removed Web-Team-Backlog.Oct 1 2015, 5:34 PM

For wikis that have one or more user-group specific MediaWiki JS page (e.g. MediaWiki:Group-user.js or MediaWiki:Group-sysop.js) and if the user is in one of those groups, then this module will be loaded. That is intended functionality.

Is has been made asynchronous after T107399.
It was also merged into user to reduce request overhead as of rMW06ab9c0942f6: resourceloader: Merge 'user.groups' into 'user' module.

Module user.groups styles should not be loaded on startup on all pagesClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Module user.groups styles should not be loaded on startup on all pages
Closed, ResolvedPublic
Actions