Page MenuHomePhabricator

Consolidate citation workflow into an inspector
Closed, ResolvedPublic8 Story Points

Description

  • The toolbar item should say "Cite" with icon, instead of just an icon with down arrow.
  • Clicking on cite shows the contextual popover (inspector)
  • Three tabs in inspector menu.
  • Automatic, manual, re-use
  • Inspector menu uses indexlayout from OOJS UI

Just to be clear about the flow for citations which is supposed to be done on 5/11/2015 EOD

[[ http://nirzar.github.io/prototypes/ve/citations/flow/tabflow/tabflow.html

The flow is here, which is common understanding of how this is going to work.

]]

Old stuff Discarded

Here is a prototype of proposed solution for fixing citations

  • The toolbar item should say "Cite" with icon, instead of just an icon with down arrow.
  • Clicking on cite shows the contextual popover (inspector)
  • Popover has two sections, automatic and manual. you can paste URL, DOI or pubmed id (isbn soon)
  • The common forms of citations are shown upfront i.e. book, news, journal and reuse and more
  • More menu opens up the dialog box with all options

Mock for reference but go through the prototype for seeing the flow.

P.S. could not find original task to update the description for it, so created a new one, feel free to merge.

Event Timeline

Nirzar created this task.Apr 28 2015, 5:41 AM
Nirzar raised the priority of this task from to Normal.
Nirzar updated the task description. (Show Details)
Nirzar added projects: VisualEditor, Design.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 28 2015, 5:41 AM

Please provide an estimate of how long it will take to implement these designs so we can plan for usability testing.

Jdforrester-WMF renamed this task from Flow for adding a new citation to Adjusted workflow for adding a new citation.Apr 30 2015, 4:55 PM
Jdforrester-WMF set Security to None.

Please provide an estimate of how long it will take to implement these designs so we can plan for usability testing.

They're still in the proposal stage right now. Assuming they're agreed, and issues are worked out, several weeks' time, I'd guess.

Issues:

  • This only shows three of the up-to five user-specified templates, and (I suppose) is meant to hide the one that's a website. Why three not four or two? How do we pick which ones? Etc.
  • This happens to use some of the shortest-named user-specified templates across all our wikis, and a very compact label for "Re-use" – in German it's "Weiterverwenden", and in Polish it's "Użyj istniejącego". What do we do when the labels are too long to show them? Do we limit the options to a single line (so show fewer), or overflow (and if so, how is that meant to look)?
  • Does the triple-dot work for users to understand that clicking it will give them more things to do in a Web context? A few years ago we were told not to use it, but that seems doubtful to me – do we have data either way? If if does work, is the current "Ellipsis" icon in OOjs UI suitable?
  • What happened to the three-tabs design from earlier (which was aligned with the new Link inspector)?
  • Please supply that "re-use" asset if we're going to switch out the current one. :-) (In RTL languages, will users expect it be flipped, or should it still be anti-clockwise?)

Engineering work:

  • Toolbar now needs to support icon+label rather than one or the other
  • Create a "section separator" layout and use it
  • Come up with a way to know which user-specified template(s) are like Cite web (?!)
  • Add label "Automatic" above the existing button
  • Change label for "Lookup" to "Generate"
  • Empty out the drop-down menu when Citoid is installed and re-use to populate the quick-list
  • Replace the blurb piece with
    • Ellipsis icon button to open the all-items dialog
    • New re-use icon button to open the all-items dialog
    • N user-specified templates as buttons along the bottom.

(I've probably missed a few things, sorry.)

What happened to the three-tabs design from earlier (which was aligned with the new Link inspector)?

The three tabs design is a better solution and I think it addresses all the issues that you have mentioned above. If the engineering effort is the same, I would prefer going that way. What do you think?

Citations

Links

Just to clarify, we need both Link inspector (which seems to be done) and Adding Citation with new flows for doing A/B testing. they are both blockers.

Neil_P._Quinn_WMF renamed this task from Adjusted workflow for adding a new citation to Consolidate citation workflow into an inspector.May 4 2015, 5:45 PM
Mvolz added a subscriber: Mvolz.May 4 2015, 7:42 PM
Mvolz moved this task from Service: Scraper & Validation to Extension on the Citoid board.
Nirzar updated the task description. (Show Details)May 4 2015, 10:06 PM
Elitre added a subscriber: Elitre.May 5 2015, 2:34 PM

Change 209198 had a related patch set uploaded (by Esanders):
Redesign CiteFromIdInspector

https://gerrit.wikimedia.org/r/209198

Jdforrester-WMF edited a custom field.May 6 2015, 9:55 PM
DarTar added a subscriber: DarTar.May 7 2015, 4:40 PM

This is probably closer to 40pts that 8.

This is probably closer to 40pts that 8.

I put it as 8 for the stuff not covered in the subsidiary tasks (which are ~ 30 points between them I think).

Nirzar updated the task description. (Show Details)May 7 2015, 10:57 PM
Nirzar assigned this task to Esanders.May 7 2015, 11:24 PM
Nirzar updated the task description. (Show Details)May 7 2015, 11:52 PM

Change 209198 merged by jenkins-bot:
Redesign CiteFromIdInspector

https://gerrit.wikimedia.org/r/209198

Jdforrester-WMF moved this task from Blocked to Q4 on the VisualEditor board.Jun 17 2015, 11:31 PM