Page MenuHomePhabricator
Create Task
Maniphest T97410

Make position of modules currently added with addModuleStyles explicit
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

I will default my changes to "top", because this is the default behavior currently provided by OutputPage. In the spirit of trying to break as little as possible, I am now making this terrible historical default into an explicit value definition. The goal being to subsequently change the default behavior of OutputPage while breaking as little as possible.

"top" is a terrible default for styles that don't need to be rendered at pageload. If one of my changesets comes your way and it's obvious that the module at hand doesn't need to be in the head, please update the position value in the changeset to be "bottom" instead.

Details

SubjectRepoBranchLines +/-
Explicitly define module positionmediawiki/extensions/TimedMediaHandlermaster+1 -0
Separate globalrenamerequest styles from scriptsmediawiki/extensions/CentralAuthmaster+6 -2
Backport Calendar module position fixmediawiki/corewmf/1.26wmf8+1 -1
Explicitly define module positionmediawiki/extensions/Calendarwmf/1.26wmf8+1 -0
Explicitly define module positionmediawiki/extensions/Calendarmaster+1 -0
Backport CodeReview module position fixmediawiki/corewmf/1.26wmf8+1 -1
Explicitly define module positionmediawiki/extensions/CodeReviewwmf/1.26wmf8+2 -0
Make ResourceLoaderWikiModule support custom positionmediawiki/corewmf/1.26wmf8+25 -12
Explicitly define module positionmediawiki/extensions/VectorBetawmf/1.26wmf8+1 -0
Explicitly define module positionmediawiki/extensions/SyntaxHighlight_GeSHiwmf/1.26wmf8+21 -3
Separate module definition for addModuleStylesmediawiki/extensions/Wikibasewmf/1.26wmf6+19 -11
Explicitly define module positionmediawiki/extensions/WikiEditorwmf/1.26wmf8+1 -0
Make ResourceLoaderWikiModule support custom positionmediawiki/coremaster+20 -7
Remove redundant position code defined in ResourceLoaderWikiModulemediawiki/extensions/SyntaxHighlight_GeSHimaster+0 -19
Explicitly define module positionmediawiki/extensions/CodeReviewmaster+2 -0
Explicitly define filepage module positionmediawiki/coremaster+1 -0
Explicitly define module positionmediawiki/extensions/VectorBetamaster+1 -0
Explicitly define module positionmediawiki/extensions/SyntaxHighlight_GeSHiwmf/1.26wmf7+40 -3
Explicitly define module positionmediawiki/extensions/Gathermaster+0 -0
Explicitly define module positionmediawiki/extensions/SyntaxHighlight_GeSHimaster+40 -3
Fix more modules' inexplicit positionsmediawiki/extensions/MobileFrontendmaster+3 -0
Acknowledge that gadgets have their position explicitly definedmediawiki/extensions/Gadgetswmf/1.26wmf8+1 -0
Acknowledge that gadgets have their position explicitly definedmediawiki/extensions/Gadgetsmaster+1 -0
Explicitly define module positionmediawiki/extensions/GlobalCssJswmf/1.26wmf7+270 -59
Explicitly define module positionmediawiki/extensions/GlobalCssJsmaster+285 -59
Explicitly define module positionmediawiki/extensions/GlobalCssJswmf/1.26wmf8+285 -59
Explicitly define module positionmediawiki/extensions/WikiEditormaster+1 -0
Explicitly define module positionmediawiki/extensions/wikihieromaster+2 -0
Separate module definition for addModuleStylesmediawiki/extensions/Wikibasemaster+19 -11
Explicitly define module positionmediawiki/extensions/MobileFrontendmaster+5 -1
Explicitly define module positionmediawiki/extensions/TimedMediaHandlermaster+6 -3
UploadWizard doesn't need addModuleStylesmediawiki/extensions/UploadWizardmaster+0 -2
Explicitly define module positionmediawiki/extensions/MobileFrontendmaster+10 -2
Explicitly define module positionmediawiki/extensions/UniversalLanguageSelectormaster+1 -0
Explicitly define module positionmediawiki/skins/CologneBluemaster+1 -0
Explicitly define module positionmediawiki/skins/Modernmaster+1 -0
Explicitly define module positionmediawiki/extensions/Wikibasemaster+5 -0
Explicitly define module positionmediawiki/skins/MonoBookmaster+1 -0
Explicitly define module positionmediawiki/skins/Modernmaster+1 -0
Explicitly define module positionmediawiki/skins/CologneBluemaster+1 -0
Explicitly define module positionmediawiki/skins/Vectormaster+1 -0
Explicitly define module positionmediawiki/extensions/UploadWizardmaster+2 -1
Explicitly define module positionmediawiki/extensions/OpenStackManagermaster+2 -0
Explicitly define module positionmediawiki/extensions/OAuthmaster+2 -0
Explicitly define module positionmediawiki/extensions/MassMessagemaster+4 -0
Explicitly define module positionmediawiki/extensions/InputBoxmaster+1 -0
Explicitly define module positionmediawiki/extensions/GettingStartedmaster+1 -0
Explicitly define module positionmediawiki/extensions/FlaggedRevsmaster+2 -1
Explicitly define module positionmediawiki/extensions/CodeReviewmaster+2 -0
Explicitly define module positionmediawiki/extensions/AbuseFiltermaster+1 -0
Explicitly define module positionmediawiki/skins/Nostalgiamaster+1 -0
Explicitly define module positionmediawiki/extensions/GlobalUserPagemaster+1 -0
Explicitly define module positionmediawiki/extensions/Flowmaster+9 -0
Explicitly define module positionmediawiki/extensions/Echomaster+3 -0
Explicitly define module positionmediawiki/extensions/CentralAuthmaster+5 -0
Explicitly define module positionmediawiki/extensions/MoodBarmaster+1 -0
Explicitly define module positionmediawiki/extensions/ZeroBannermaster+2 -0
Explicitly define module positionmediawiki/extensions/WikimediaIncubatormaster+1 -0
Explicitly define module positionmediawiki/extensions/Wikidatamaster+1 -0
Explicitly define module positionmediawiki/extensions/ProofreadPagemaster+2 -0
Explicitly define module positionmediawiki/extensions/Gathermaster+3 -0
Explicitly define module positionmediawiki/extensions/Calendarmaster+1 -0
Explicitly define module positionmediawiki/extensions/CategoryTreemaster+1 -0
Explicitly define module positionmediawiki/extensions/Babelmaster+1 -0
Explicitly define module positionmediawiki/extensions/VisualEditormaster+2 -0
Explicitly define module positionmediawiki/extensions/CiteThisPagemaster+1 -0
Explicitly define module positionmediawiki/extensions/Mathmaster+2 -0
Explicitly define module positionmediawiki/extensions/ConfirmEditmaster+1 -0
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Diffusion mentioned this in rMEXT899bb021a208: Updated mediawiki/extensions Project: mediawiki/extensions/GlobalCssJs….May 28 2015, 6:14 PM
gerritbot added a comment.May 28 2015, 6:15 PM

Change 214399 had a related patch set uploaded (by Legoktm):
Explicitly define module position

https://gerrit.wikimedia.org/r/214399

Legoktm mentioned this in rEGCJ3e05e3810ed5: Explicitly define module position.May 28 2015, 6:16 PM
gerritbot added a comment.May 28 2015, 6:19 PM

Change 214399 merged by jenkins-bot:
Explicitly define module position

https://gerrit.wikimedia.org/r/214399

Legoktm mentioned this in rEGCJb224afb32091: Explicitly define module position.May 28 2015, 6:19 PM
gerritbot added a comment.May 28 2015, 6:27 PM

Change 214401 had a related patch set uploaded (by Legoktm):
Explicitly define module position

https://gerrit.wikimedia.org/r/214401

gerritbot added a comment.May 28 2015, 6:30 PM

Change 214401 merged by Legoktm:
Explicitly define module position

https://gerrit.wikimedia.org/r/214401

Legoktm mentioned this in rEGCJ5e7a5bf2741a: Explicitly define module position.May 28 2015, 6:30 PM
gerritbot added a comment.May 28 2015, 6:46 PM

Change 213804 merged by jenkins-bot:
Acknowledge that gadgets have their position explicitly defined

https://gerrit.wikimedia.org/r/213804

Diffusion mentioned this in rMEXTffba5a2f2bf1: Updated mediawiki/extensions Project: mediawiki/extensions/Gadgets….May 28 2015, 6:46 PM
• Gilles mentioned this in rEGAD3b141e727670: Acknowledge that gadgets have their position explicitly defined.May 28 2015, 6:46 PM
gerritbot added a comment.May 28 2015, 6:47 PM

Change 214406 had a related patch set uploaded (by Legoktm):
Acknowledge that gadgets have their position explicitly defined

https://gerrit.wikimedia.org/r/214406

gerritbot added a comment.May 28 2015, 6:50 PM

Change 214406 merged by jenkins-bot:
Acknowledge that gadgets have their position explicitly defined

https://gerrit.wikimedia.org/r/214406

Legoktm mentioned this in rEGADccea978927b7: Acknowledge that gadgets have their position explicitly defined.May 28 2015, 6:51 PM
gerritbot added a comment.May 28 2015, 6:55 PM

Change 214408 had a related patch set uploaded (by Gilles):
Fix more modules' inexplicit positions

https://gerrit.wikimedia.org/r/214408

gerritbot added a comment.May 28 2015, 6:58 PM

Change 214410 had a related patch set uploaded (by Gilles):
Explicitly define module position

https://gerrit.wikimedia.org/r/214410

gerritbot added a comment.May 28 2015, 7:00 PM

Change 214411 had a related patch set uploaded (by Gilles):
Explicitly define module position

https://gerrit.wikimedia.org/r/214411

gerritbot added a comment.May 28 2015, 9:25 PM

Change 214408 abandoned by Gilles:
Fix more modules' inexplicit positions

https://gerrit.wikimedia.org/r/214408

TheDJ merged a task: T100697: Warning: OutputPage::getModuleStyles: style module should define its position explicitly: ext.geshi.language.bash ResourceLoaderGeSHiModule [Called from OutputPage::getModuleStyles in /srv/mediawiki/php-1.26wmf8/includes/OutputPage.php at line 603] in /srv/mediawiki/php-1.26wmf8/includes/debug/MWDebug.php on line 300.May 29 2015, 7:25 AM
TheDJ added subscribers: matmarex, hashar.
hashar added a project: Wikimedia-production-error.May 29 2015, 7:43 AM

Since the position is to be explicit, can we have a RL test that assert the position is defined? Can be made in tests/phpunit/structure/ResourcesTest.php. Beware that tests there are run for all extensions.

Edokter subscribed.May 29 2015, 8:21 AM

I thought the point of all CSS loading at top by default is that there is no point in loading CSS at the bottom. I can think of no scenario where CSS is not needed at page load. The only possible advantage is that content comes sooner, but you also risk style flashes.

• Gilles added a comment.May 29 2015, 11:06 AM

@Edokter a notable exception, which is the use case this change was needed for (in MobileFrontend), is icons embedded in the CSS which are needed by the regular site as well as the no-JS site. As long as the space for the icons is reserved for them, which is the case on mobile web, there is no reflow, the icons just appear in place. Just like any other image on the page, such as thumbnails inside the article.

Furthermore, ignoring the no-JS/JS issue for a second, CSS can and should definitely loaded on demand when it makes sense, like for example if you invoke a modal dialog or a menu that has its own styles, not share with the main page.

You can also decide to make some concessions like having the hover and pressed styles of buttons loaded later. Any style whose loading won't cause the content to reflow, really.

The upside to getting rid of as much CSS in the head is huge as it helps display the page much sooner, particularly on the mobile site which is browsed by people with very slow connections.

As an aside, I've started discussing this idea: T100778 which might allow us to get rid of addModuleStyles entirely. These icons embedded in CSS would still be bottom-loaded, but in a much nicer way using ResourceLoader.

gerritbot added a comment.May 29 2015, 2:51 PM

Change 214619 had a related patch set uploaded (by Aude):
Separate module definition for addModuleStyles

https://gerrit.wikimedia.org/r/214619

gerritbot added a comment.May 29 2015, 3:29 PM

Change 207086 merged by jenkins-bot:
Explicitly define module position

https://gerrit.wikimedia.org/r/207086

• Gilles mentioned this in rMEXT8f37368fc2b7: Updated mediawiki/extensions Project….May 29 2015, 3:29 PM
bd808 mentioned this in rESHG58c81408f5da: Explicitly define module position.May 29 2015, 3:29 PM
gerritbot added a comment.May 29 2015, 3:29 PM

Change 214632 had a related patch set uploaded (by BryanDavis):
Explicitly define module position

https://gerrit.wikimedia.org/r/214632

gerritbot added a comment.May 29 2015, 3:29 PM

Change 214633 had a related patch set uploaded (by BryanDavis):
Explicitly define module position

https://gerrit.wikimedia.org/r/214633

gerritbot added a comment.May 29 2015, 5:53 PM

Change 214410 merged by jenkins-bot:
Explicitly define module position

https://gerrit.wikimedia.org/r/214410

• Gilles mentioned this in rMEXT11e9f2b395fc: Updated mediawiki/extensions Project: mediawiki/extensions/VectorBeta….May 29 2015, 5:53 PM
gerritbot added a comment.May 29 2015, 5:54 PM

Change 214411 abandoned by Gilles:
Explicitly define module position

Reason:
It's empty...

https://gerrit.wikimedia.org/r/214411

• Gilles mentioned this in rEVEBcbd610331b59: Explicitly define module position.May 29 2015, 5:54 PM
gerritbot added a comment.May 29 2015, 6:47 PM

Change 214632 abandoned by Jforrester:
Explicitly define module position

Reason:
Not needed, breaking core change is wmf8 only.

https://gerrit.wikimedia.org/r/214632

gerritbot added a comment.May 29 2015, 6:48 PM

Change 214669 had a related patch set uploaded (by Jforrester):
Explicitly define module position

https://gerrit.wikimedia.org/r/214669

gerritbot added a comment.May 29 2015, 7:33 PM

Change 214683 had a related patch set uploaded (by Gilles):
Explicitly define module position

https://gerrit.wikimedia.org/r/214683

gerritbot added a comment.May 29 2015, 8:00 PM

Change 214695 had a related patch set uploaded (by Gilles):
Make ResourceLoaderWikiModule support custom position

https://gerrit.wikimedia.org/r/214695

gerritbot added a comment.May 29 2015, 8:05 PM

Change 214698 had a related patch set uploaded (by Gilles):
Remove redundant position code defined in ResourceLoaderWikiModule

https://gerrit.wikimedia.org/r/214698

gerritbot added a comment.May 29 2015, 8:07 PM

Change 214683 merged by jenkins-bot:
Explicitly define module position

https://gerrit.wikimedia.org/r/214683

• Gilles mentioned this in rMEXT32baef1f81d2: Updated mediawiki/extensions Project: mediawiki/extensions/CodeReview….May 29 2015, 8:07 PM
• Gilles mentioned this in rECRE2205a02a53d8: Explicitly define module position.May 29 2015, 8:11 PM
gerritbot added a comment.May 29 2015, 8:40 PM

Change 214695 merged by jenkins-bot:
Make ResourceLoaderWikiModule support custom position

https://gerrit.wikimedia.org/r/214695

bd808 mentioned this in rMW9a8ed7862714: Make ResourceLoaderWikiModule support custom position.May 29 2015, 8:40 PM
gerritbot added a comment.May 29 2015, 8:43 PM

Change 214698 merged by jenkins-bot:
Remove redundant position code defined in ResourceLoaderWikiModule

https://gerrit.wikimedia.org/r/214698

• Gilles mentioned this in rESHG097fc9069ae4: Remove redundant position code defined in ResourceLoaderWikiModule.May 29 2015, 8:43 PM
• Gilles mentioned this in rMEXT6a3bea7f9495: Updated mediawiki/extensions Project….
gerritbot added a comment.May 29 2015, 8:43 PM

Change 214741 had a related patch set uploaded (by Gilles):
Make ResourceLoaderWikiModule support custom position

https://gerrit.wikimedia.org/r/214741

• Forrestbot added a project: WMF-deploy-2015-06-09_(1.26wmf9).May 29 2015, 9:00 PM
gerritbot added a comment.May 30 2015, 5:02 PM

Change 214310 merged by jenkins-bot:
Explicitly define module position

https://gerrit.wikimedia.org/r/214310

Legoktm mentioned this in rEWED0e693f588691: Explicitly define module position.May 30 2015, 5:05 PM
gerritbot added a comment.Jun 1 2015, 10:19 AM

Change 214619 merged by jenkins-bot:
Separate module definition for addModuleStyles

https://gerrit.wikimedia.org/r/214619

aude mentioned this in rEWBA1578ad3bedc9: Separate module definition for addModuleStyles.Jun 1 2015, 10:20 AM
gerritbot added a comment.Jun 1 2015, 1:16 PM

Change 214633 merged by jenkins-bot:
Explicitly define module position

https://gerrit.wikimedia.org/r/214633

gerritbot added a comment.Jun 1 2015, 1:16 PM

Change 214669 merged by jenkins-bot:
Explicitly define module position

https://gerrit.wikimedia.org/r/214669

bd808 mentioned this in rESHGcff59622c470: Explicitly define module position.Jun 1 2015, 1:17 PM
Jdforrester-WMF mentioned this in rEVEB384f573885c8: Explicitly define module position.Jun 1 2015, 1:27 PM
gerritbot added a comment.Jun 1 2015, 3:14 PM

Change 214741 merged by jenkins-bot:
Make ResourceLoaderWikiModule support custom position

https://gerrit.wikimedia.org/r/214741

• Gilles mentioned this in rMW50dafc295480: Make ResourceLoaderWikiModule support custom position.Jun 1 2015, 3:14 PM
gerritbot added a comment.Jun 1 2015, 3:30 PM

Change 215041 had a related patch set uploaded (by Gilles):
Explicitly define module position

https://gerrit.wikimedia.org/r/215041

gerritbot added a comment.Jun 1 2015, 3:31 PM

Change 215041 merged by jenkins-bot:
Explicitly define module position

https://gerrit.wikimedia.org/r/215041

gerritbot added a comment.Jun 1 2015, 3:34 PM

Change 215043 had a related patch set uploaded (by Gilles):
Backport CodeReview module position fix

https://gerrit.wikimedia.org/r/215043

• Gilles mentioned this in rECRE50e616c9088b: Explicitly define module position.Jun 1 2015, 3:38 PM
gerritbot added a comment.Jun 1 2015, 3:44 PM

Change 215043 merged by jenkins-bot:
Backport CodeReview module position fix

https://gerrit.wikimedia.org/r/215043

• Gilles mentioned this in rMW4f76407df62c: Backport CodeReview module position fix.Jun 1 2015, 3:44 PM
• Gilles added a comment.Jun 1 2015, 4:02 PM

All warnings in group 0 wikis should have been addressed now.

bd808 moved this task from Untriaged to Jan 2019 / 1.33.wmf13–14 on the Wikimedia-production-error board.Jun 1 2015, 4:30 PM
• Gilles removed a project: Patch-For-Review.Jun 2 2015, 8:26 AM
gerritbot added a comment.Jun 2 2015, 11:21 PM

Change 215545 had a related patch set uploaded (by Gilles):
Explicitly define module position

https://gerrit.wikimedia.org/r/215545

gerritbot added a project: Patch-For-Review.Jun 2 2015, 11:21 PM

Change 215546 had a related patch set uploaded (by Gilles):
Explicitly define module position

https://gerrit.wikimedia.org/r/215546

gerritbot added a comment.Jun 2 2015, 11:24 PM

Change 215545 merged by jenkins-bot:
Explicitly define module position

https://gerrit.wikimedia.org/r/215545

gerritbot added a comment.Jun 2 2015, 11:24 PM

Change 215546 merged by jenkins-bot:
Explicitly define module position

https://gerrit.wikimedia.org/r/215546

• Gilles mentioned this in rMEXT831214f84d2e: Updated mediawiki/extensions Project: mediawiki/extensions/Calendar….Jun 2 2015, 11:24 PM
gerritbot added a comment.Jun 2 2015, 11:27 PM

Change 215547 had a related patch set uploaded (by Gilles):
Backport Calendar module position fix

https://gerrit.wikimedia.org/r/215547

• Gilles mentioned this in rECAL4e3404f34f04: Explicitly define module position.Jun 2 2015, 11:30 PM
• Gilles mentioned this in rECALbdd2ca6f6562: Explicitly define module position.
gerritbot added a comment.Jun 3 2015, 12:30 AM

Change 215547 merged by jenkins-bot:
Backport Calendar module position fix

https://gerrit.wikimedia.org/r/215547

• Gilles mentioned this in rMWab60d0d111e5: Backport Calendar module position fix.Jun 3 2015, 12:31 AM
hashar added subtasks: T100950: style module should define its position explicitly: ext.translate.mainpage.styles, T101076: Fix warning "OutputPage::getModuleStyles : module should define its position explicitly: jquery.wikibase.toolbar".Jun 3 2015, 12:48 PM
JanZerebecki closed subtask T101076: Fix warning "OutputPage::getModuleStyles : module should define its position explicitly: jquery.wikibase.toolbar" as Resolved.Jun 3 2015, 1:19 PM
Krinkle subscribed.EditedJun 4 2015, 1:34 PM
@Krinkle merged Ic8d3d63b1 in mediawiki/extensions/WikimediaMessages:

modules: Add position=top to style module

https://gerrit.wikimedia.org/r/215862

• Gilles closed this task as Resolved.Jun 9 2015, 7:07 AM
• Gilles closed subtask T100950: style module should define its position explicitly: ext.translate.mainpage.styles as Resolved.
gerritbot added a comment.Jun 9 2015, 6:26 PM

Change 210006 merged by jenkins-bot:
Separate globalrenamerequest styles from scripts

https://gerrit.wikimedia.org/r/210006

Krinkle mentioned this in rECAUe301aebc037f: Separate globalrenamerequest styles from scripts.Jun 9 2015, 6:27 PM
Diffusion mentioned this in rMEXT1feaeb8c9dc5: Updated mediawiki/extensions Project: mediawiki/extensions/CentralAuth….Jun 9 2015, 6:27 PM
• Forrestbot added a project: WMF-deploy-2015-06-16_(1.26wmf10).Jun 9 2015, 7:00 PM
gerritbot added a comment.Jun 9 2015, 10:47 PM

Change 217180 had a related patch set uploaded (by Paladox):
Explicitly define module position

https://gerrit.wikimedia.org/r/217180

gerritbot added a comment.Jun 10 2015, 3:27 PM

Change 217180 abandoned by Paladox:
Explicitly define module position

Reason:
It seems that updating to latest branched version fixed problem.

https://gerrit.wikimedia.org/r/217180

• demon moved this task from Jan 2019 / 1.33.wmf13–14 to Resolved on the Wikimedia-production-error board.Jun 12 2015, 6:31 PM
Legoktm removed a subscriber: • Forrestbot.Jun 29 2015, 5:49 PM
• Gilles mentioned this in rMREL2dfa95be8354: Explicitly define module position.Jul 14 2015, 6:11 PM
• Gilles mentioned this in rSVEVd4fef458afab: Explicitly define module position.Mar 8 2016, 3:29 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL