Page MenuHomePhabricator
Create Task
Maniphest T97416

[Bug] Fatal error: Uncaught exception 'MWContentSerializationException' when running core phpunit tests, with wikibase repo installed
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

I have item content in the main namespace, which seems to be the problem here.

tests should be more robust and be able to handle or work around this.

Fatal error: Uncaught exception 'MWContentSerializationException' with message 'Failed to decode as ' in /var/www/wiki/core/extensions/Wikidata/extensions/Wikibase/lib/includes/store/EntityContentDataCodec.php:201
Stack trace:
#0 /var/www/wiki/core/extensions/Wikidata/extensions/Wikibase/lib/includes/store/EntityContentDataCodec.php(250): Wikibase\Lib\Store\EntityContentDataCodec->decodeEntityContentData()
#1 /var/www/wiki/core/extensions/Wikidata/extensions/Wikibase/repo/includes/content/EntityHandler.php(394): Wikibase\Lib\Store\EntityContentDataCodec->decodeRedirect()
#2 /var/www/wiki/core/includes/content/ContentHandler.php(156): Wikibase\Repo\Content\EntityHandler->unserializeContent()
#3 /var/www/wiki/core/tests/phpunit/MediaWikiTestCase.php(440): ContentHandler::makeContent()
#4 /var/www/wiki/core/tests/phpunit/includes/PrefixSearchTest.php(9): MediaWikiTestCase->insertPage()
#5 /var/www/wiki/core/tests/phpunit/MediaWikiTestCase.php(127): PrefixSearchTest->addDBData()
#6 /var/www/wiki/core/vendor/phpunit/phpunit/src/Framework/TestSuite.php(722): MediaWikiTestCase->run()
#7 /var/www/wiki/core/vendor/phpunit/phpunit/src/Framework/TestSuite.php(722): PHPUnit_Framework_TestSuite->run()
#8 /var/www/wiki/core/vendor/phpunit/phpunit/src/Framework/TestSuite.php(722): PHPUnit_Framework_TestSuite->run()
#9 /var/www/wiki/core/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(406): PHPUnit_Framework_TestSuite->run()
#10 /var/www/wiki/core/vendor/phpunit/phpunit/src/TextUI/Command.php(153): PHPUnit_TextUI_TestRunner->doRun()
#11 /var/www/wiki/core/vendor/phpunit/phpunit/src/TextUI/Command.php(105): PHPUnit_TextUI_Command->run()
#12 /var/www/wiki/core/tests/phpunit/phpunit.php(241): PHPUnit_TextUI_Command::main()
#13 {main}
[50c1446e] [no req] MWContentSerializationException from line 201 of /var/www/wiki/core/extensions/Wikidata/extensions/Wikibase/lib/includes/store/EntityContentDataCodec.php: Failed to decode as
Backtrace:
#0 /var/www/wiki/core/extensions/Wikidata/extensions/Wikibase/lib/includes/store/EntityContentDataCodec.php(250): Wikibase\Lib\Store\EntityContentDataCodec->decodeEntityContentData(string, NULL)
#1 /var/www/wiki/core/extensions/Wikidata/extensions/Wikibase/repo/includes/content/EntityHandler.php(394): Wikibase\Lib\Store\EntityContentDataCodec->decodeRedirect(string, NULL)
#2 /var/www/wiki/core/includes/content/ContentHandler.php(156): Wikibase\Repo\Content\EntityHandler->unserializeContent(string, NULL)
#3 /var/www/wiki/core/tests/phpunit/MediaWikiTestCase.php(440): ContentHandler::makeContent(string, Title)
#4 /var/www/wiki/core/tests/phpunit/includes/PrefixSearchTest.php(9): MediaWikiTestCase->insertPage(string)
#5 /var/www/wiki/core/tests/phpunit/MediaWikiTestCase.php(127): PrefixSearchTest->addDBData()
#6 /var/www/wiki/core/vendor/phpunit/phpunit/src/Framework/TestSuite.php(722): MediaWikiTestCase->run(PHPUnit_Framework_TestResult)
#7 /var/www/wiki/core/vendor/phpunit/phpunit/src/Framework/TestSuite.php(722): PHPUnit_Framework_TestSuite->run(PHPUnit_Framework_TestResult)
#8 /var/www/wiki/core/vendor/phpunit/phpunit/src/Framework/TestSuite.php(722): PHPUnit_Framework_TestSuite->run(PHPUnit_Framework_TestResult)
#9 /var/www/wiki/core/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(406): PHPUnit_Framework_TestSuite->run(PHPUnit_Framework_TestResult)
#10 /var/www/wiki/core/vendor/phpunit/phpunit/src/TextUI/Command.php(153): PHPUnit_TextUI_TestRunner->doRun(PHPUnit_Framework_TestSuite, array)
#11 /var/www/wiki/core/vendor/phpunit/phpunit/src/TextUI/Command.php(105): PHPUnit_TextUI_Command->run(array, boolean)
#12 /var/www/wiki/core/tests/phpunit/phpunit.php(241): PHPUnit_TextUI_Command::main()

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+5 -0Skip adding wikitext test pages in PrefixSearchTest if NS_MAIN is not wikitext
Customize query in gerrit

Related Objects

Event Timeline

aude created this task.Apr 28 2015, 2:01 PM
aude raised the priority of this task from to Needs Triage.
aude updated the task description. (Show Details)
aude added a project: MediaWiki-Core-Testing.
aude added a subscriber: aude.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 28 2015, 2:01 PM
Umherirrender added a project: MediaWiki-extensions-WikibaseRepository.Apr 28 2015, 5:33 PM
Umherirrender set Security to None.
Lydia_Pintscher added a project: Wikidata.May 4 2015, 4:14 PM
JanZerebecki added a subscriber: JanZerebecki.May 15 2015, 6:43 PM

It seems to try to create a normal page in the main namespace which is configured to be items only. How should the test pick the namespace to create the test page in?

JanZerebecki triaged this task as Medium priority.May 15 2015, 6:43 PM
JanZerebecki moved this task from incoming to needs discussion or investigation on the Wikidata board.
aude added a comment.Aug 14 2015, 9:16 AM

still happens

aude added a comment.Aug 14 2015, 9:17 AM

@JanZerebecki MediaWikiTestCase has getDefaultWikitextNS that can be used and in some places something like NS_HELP is used. (assumed to always be wikitext)

aude renamed this task from Fatal error: Uncaught exception 'MWContentSerializationException' when running core phpunit tests, with wikibase repo installed to [Bug] Fatal error: Uncaught exception 'MWContentSerializationException' when running core phpunit tests, with wikibase repo installed.Aug 14 2015, 9:18 AM
Addshore added a subscriber: Addshore.Aug 14 2015, 9:18 AM
gerritbot added a subscriber: gerritbot.Aug 14 2015, 9:34 AM

Change 231501 had a related patch set uploaded (by Aude):
Skip adding wikitext test pages in PrefixSearchTest if NS_MAIN is not wikitext

https://gerrit.wikimedia.org/r/231501

gerritbot added a project: Patch-For-Review.Aug 14 2015, 9:34 AM
aude claimed this task.Aug 14 2015, 9:36 AM
aude added a project: Wikidata-Sprint-2015-08-11.
aude moved this task from Backlog to Review on the Wikidata-Sprint-2015-08-11 board.
Lydia_Pintscher edited a custom field.Aug 14 2015, 10:35 AM
Lydia_Pintscher added a project: Wikidata-Sprint-2015-08-18.Aug 18 2015, 1:20 PM
Lydia_Pintscher added subscribers: hoo, daniel.
JanZerebecki moved this task from Backlog to Review on the Wikidata-Sprint-2015-08-18 board.Aug 18 2015, 1:23 PM
Lydia_Pintscher moved this task from needs discussion or investigation to in progress on the Wikidata board.Aug 20 2015, 9:08 AM
gerritbot added a comment.Aug 20 2015, 5:18 PM

Change 231501 merged by jenkins-bot:
Skip adding wikitext test pages in PrefixSearchTest if NS_MAIN is not wikitext

https://gerrit.wikimedia.org/r/231501

aude mentioned this in rMW515c81b048f5: Skip adding wikitext test pages in PrefixSearchTest if NS_MAIN is not wikitext.Aug 20 2015, 5:18 PM
Addshore closed this task as Resolved.Aug 20 2015, 5:51 PM
Addshore moved this task from Review to Done on the Wikidata-Sprint-2015-08-18 board.
Forrestbot added projects: MW-1.26-release, WMF-deploy-2015-08-25_(1.26wmf20).Aug 20 2015, 6:00 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL