Clean up mess from copy-pasted tables
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

I pasted a table into VisualEditor. CSV imports are working really well for me, but rich copying and pasting a table resulted in a lot of this stuff:

colspan="1" rowspan="1" id="banner_0_0_0_header_0" class="header Editable"

I'd like to see meaningless text removed automatically.

Details

	Subject	Repo	Branch	Lines +/-
	MWTable: use new sanitization method	mediawiki/extensions/VisualEditor	master	+10 -32

Customize query in gerrit

Related Objects

Mentioned In: T125220: [Regression pre-wmf.12] Copying a plain table to another VE instance converts it to a wikitable

Event Timeline

• Whatamidoing-WMF created this task.Apr 28 2015, 7:28 PM

• Whatamidoing-WMF raised the priority of this task from to Needs Triage.

• Whatamidoing-WMF updated the task description. (Show Details)

• Whatamidoing-WMF added projects: VisualEditor, VisualEditor-Tables.

• Whatamidoing-WMF subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 28 2015, 7:28 PM

@Whatamidoing-WMF, can you give an example of a table or file that causes these problems? I just tried copy-and-pasting from a CSV file open in LibreOffice, and it worked fine. Thanks!

nshahquinn-wmf triaged this task as Medium priority.May 14 2015, 7:28 PM

nshahquinn-wmf set Security to None.

I encountered this when copying a table off the Qualtrics website. CSV file importing is not the problem; rich coping and pasting of heavily formatted tables is the problem.

@Whatamidoing-WMF, maybe you could paste the Qualtrics table in a Google Doc (or something) and link that doc here so we have a clear test case?

Quiddity added a project: VisualEditor-CopyPaste.Jun 18 2015, 12:16 AM

Quiddity subscribed.

Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Jun 18 2015, 1:01 AM

VE should be stripping all HTML attributes for external paste, so can we get precise reproduction steps?

Esanders mentioned this in T125220: [Regression pre-wmf.12] Copying a plain table to another VE instance converts it to a wikitable.Jan 29 2016, 4:26 PM

Change 267287 had a related patch set uploaded (by Esanders):
MWTable: use new sanitization method

https://gerrit.wikimedia.org/r/267287

gerritbot added a project: Patch-For-Review.Jan 29 2016, 5:46 PM

I couldn't reproduce 'id' preservation, but col/rowspan=1 is still and issue after this fix. Unfortunately we don't yet have an MWTableCellNode class so the fix is not quite as trivial

Quiddity unsubscribed.Jan 29 2016, 5:55 PM

Jdforrester-WMF closed this task as Resolved.Jan 29 2016, 6:37 PM

Jdforrester-WMF assigned this task to Esanders.

Jdforrester-WMF removed a project: Patch-For-Review.

Jdforrester-WMF edited a custom field.

Change 267287 merged by jenkins-bot:
MWTable: use new sanitization method

https://gerrit.wikimedia.org/r/267287

Jdforrester-WMF added a project: MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)).Jan 29 2016, 7:13 PM

Jdforrester-WMF moved this task from Freezer to TR0: Interrupt on the VisualEditor board.Jan 30 2016, 3:28 AM