Page MenuHomePhabricator

Editor broken on new pages
Closed, ResolvedPublic

Description

Picked up by our browser tests. W00t!
Click edit in mobile mode (non-VE mode) and everything explodes

Exception in load-callback in module mobile.editor.overlay:
TypeError: Cannot read property 'hasOwnProperty' of undefined TypeError: Cannot read property 'hasOwnProperty' of undefined {stack: (...), message: "Cannot read property 'hasOwnProperty' of undefined"}

https://integration.wikimedia.org/ci/view/Mobile/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/630/testReport/junit/(root)/Wikitext%20Editor%20(Makes%20actual%20saves)/Broken_redirects/ fails because of this

Event Timeline

Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Readers-Web-Backlog.
Jdlrobson moved this task to Incoming on the Readers-Web-Backlog board.
Jdlrobson added a subscriber: Jdlrobson.
Jdlrobson set Security to None.

Change 207634 had a related patch set uploaded (by Bmansurov):
Check whether the object exists before checking its property

https://gerrit.wikimedia.org/r/207634

Change 207634 merged by jenkins-bot:
Check whether the object exists before checking its property

https://gerrit.wikimedia.org/r/207634

kaldari added a subscriber: kaldari.

Change 207678 had a related patch set uploaded (by Catrope):
Check whether the object exists before checking its property

https://gerrit.wikimedia.org/r/207678

Change 207678 merged by jenkins-bot:
Check whether the object exists before checking its property

https://gerrit.wikimedia.org/r/207678