Maniphest T97474

Editor broken on new pages
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Apr 28 2015, 9:13 PM

Tags

Referenced Files

None

Subscribers

Description

Picked up by our browser tests. W00t!
Click edit in mobile mode (non-VE mode) and everything explodes

Exception in load-callback in module mobile.editor.overlay:
TypeError: Cannot read property 'hasOwnProperty' of undefined TypeError: Cannot read property 'hasOwnProperty' of undefined {stack: (...), message: "Cannot read property 'hasOwnProperty' of undefined"}

https://integration.wikimedia.org/ci/view/Mobile/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/630/testReport/junit/(root)/Wikitext%20Editor%20(Makes%20actual%20saves)/Broken_redirects/ fails because of this

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Check whether the object exists before checking its property	mediawiki/extensions/MobileFrontend	wmf/1.26wmf4	+1 -1
	Check whether the object exists before checking its property	mediawiki/extensions/MobileFrontend	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: rMW41d64b0a85e4: Updated mediawiki/core Project: mediawiki/extensions/MobileFrontend…
rEMFR5d7d45d74a95: Check whether the object exists before checking its property
rEMFRbb7b9469d8c9: Check whether the object exists before checking its property
rMEXT0cfda32a40d6: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend…
T97460: Update browser tests after login/sign up form warning changes

Event Timeline

Jdlrobson created this task.Apr 28 2015, 9:13 PM

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Web-Team-Backlog-Archived.

Jdlrobson moved this task to Incoming on the Web-Team-Backlog-Archived board.

Jdlrobson subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 28 2015, 9:13 PM

Jdlrobson mentioned this in T97460: Update browser tests after login/sign up form warning changes.Apr 28 2015, 9:13 PM

Jdlrobson triaged this task as High priority.Apr 28 2015, 10:20 PM

Jdlrobson set Security to None.

• KLans_WMF moved this task from Incoming to Old Unorganized Resolved Tasks on the Web-Team-Backlog-Archived board.Apr 29 2015, 5:15 PM

• KLans_WMF added a project: Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story.

• KLans_WMF moved this task from Needs Analysis to To Do on the Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story board.Apr 29 2015, 8:06 PM

• bmansurov claimed this task.Apr 29 2015, 9:03 PM

Change 207634 had a related patch set uploaded (by Bmansurov):
Check whether the object exists before checking its property

https://gerrit.wikimedia.org/r/207634

gerritbot added a project: Patch-For-Review.Apr 29 2015, 9:03 PM

• bmansurov moved this task from To Do to Code Review on the Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story board.Apr 29 2015, 9:03 PM

Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story board.Apr 29 2015, 9:51 PM

Jdlrobson moved this task from -1 (Needs More Work) to Ready for Signoff on the Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story board.

Change 207634 merged by jenkins-bot:
Check whether the object exists before checking its property

https://gerrit.wikimedia.org/r/207634

• bmansurov mentioned this in rMEXT0cfda32a40d6: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Apr 29 2015, 9:52 PM

• bmansurov mentioned this in rEMFRbb7b9469d8c9: Check whether the object exists before checking its property.

kaldari closed this task as Resolved.Apr 29 2015, 9:55 PM

kaldari subscribed.

Change 207678 had a related patch set uploaded (by Catrope):
Check whether the object exists before checking its property

https://gerrit.wikimedia.org/r/207678

Change 207678 merged by jenkins-bot:
Check whether the object exists before checking its property

https://gerrit.wikimedia.org/r/207678

Catrope mentioned this in rEMFR5d7d45d74a95: Check whether the object exists before checking its property.Apr 29 2015, 11:43 PM

• bmansurov mentioned this in rMW41d64b0a85e4: Updated mediawiki/core Project: mediawiki/extensions/MobileFrontend….Apr 29 2015, 11:43 PM

phuedx moved this task from Ready for Signoff to Done on the Mobile-Web-Sprint-46-Taken:-The-Dan-Garry-Story board.Apr 30 2015, 8:44 AM

phuedx removed a project: Patch-For-Review.

• Phabricator_maintenance moved this task from Old Unorganized Resolved Tasks to 2014-15 Q4 on the Web-Team-Backlog-Archived board.Mar 7 2018, 1:23 AM