Page MenuHomePhabricator

Editor broken on new pages
Closed, ResolvedPublic

Description

Picked up by our browser tests. W00t!
Click edit in mobile mode (non-VE mode) and everything explodes

Exception in load-callback in module mobile.editor.overlay:
TypeError: Cannot read property 'hasOwnProperty' of undefined TypeError: Cannot read property 'hasOwnProperty' of undefined {stack: (...), message: "Cannot read property 'hasOwnProperty' of undefined"}

https://integration.wikimedia.org/ci/view/Mobile/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/630/testReport/junit/(root)/Wikitext%20Editor%20(Makes%20actual%20saves)/Broken_redirects/ fails because of this

Event Timeline

Jdlrobson updated the task description. (Show Details)
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson moved this task to To Triage on the Readers-Web-Backlog board.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 28 2015, 9:13 PM
Jdlrobson triaged this task as High priority.Apr 28 2015, 10:20 PM
Jdlrobson set Security to None.

Change 207634 had a related patch set uploaded (by Bmansurov):
Check whether the object exists before checking its property

https://gerrit.wikimedia.org/r/207634

Change 207634 merged by jenkins-bot:
Check whether the object exists before checking its property

https://gerrit.wikimedia.org/r/207634

kaldari closed this task as Resolved.Apr 29 2015, 9:55 PM
kaldari added a subscriber: kaldari.

Change 207678 had a related patch set uploaded (by Catrope):
Check whether the object exists before checking its property

https://gerrit.wikimedia.org/r/207678

Change 207678 merged by jenkins-bot:
Check whether the object exists before checking its property

https://gerrit.wikimedia.org/r/207678