Page MenuHomePhabricator

If a parameter is marked as suggested or required in TemplateData, then always display that parameter in the template dialog
Closed, ResolvedPublic8 Story Points

Description

Current situation: When you insert a new template, suggested and required parameters are displayed (blank, of course) in the template dialog. When you edit an existing template, then only the parameters that were previously used/added to the template are displayed.

Preferred situation: If you are in the template dialog, then suggested and required parameters are displayed—no exceptions, new and old templates alike.

Always displaying all of the suggested and required parameters should make repairing or completing templates faster and easier.

Event Timeline

Whatamidoing-WMF updated the task description. (Show Details)
Whatamidoing-WMF raised the priority of this task from to Needs Triage.
Whatamidoing-WMF added a subscriber: Whatamidoing-WMF.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 28 2015, 10:30 PM
Neil_P._Quinn_WMF triaged this task as Normal priority.
Neil_P._Quinn_WMF set Security to None.

This change would be enormously helpful for editors trying to improve references. Many editors leave a bare url plus a page number (or range of pages). Converting a pure bare url to a proper reference is often trivial (just click on Convert), but the existence of page numbers makes it a tedious task. Automatically including the page and pages field would make this much easier.

Change 288650 had a related patch set uploaded (by Jforrester):
MWTemplateDialog: When opening the dialog, add in any unset suggested and required parameters

https://gerrit.wikimedia.org/r/288650

Jdforrester-WMF claimed this task.
Jdforrester-WMF set the point value for this task to 1.
Jdforrester-WMF closed this task as Resolved.Jun 29 2016, 10:39 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF changed the point value for this task from 1 to 8.

Change 288650 merged by jenkins-bot:
MWTemplateDialog: When opening the dialog, add in any unset suggested and required parameters

https://gerrit.wikimedia.org/r/288650

I see this is marked as resolved, but I just tried it but did not seem to work the way I had expected.

Here is my edit:
https://en.wikipedia.org/w/index.php?title=Kumina&type=revision&diff=727584616&oldid=726486989

I had originally expected that the convert step would add a field for page number possibly filled out possibly not, but that did not happen. However, I checked and the link now goes to the proper page. I believe the prior result was that it would bring you to the first page so arguably this is an even better result although some might wish that the page number be specifically included in the citation.

It does seem to solve the problem I had so I will begin using it again — I just note that some practitioners may desire the page number field.

My next test failed. I'll put together something a bit more formal.

I see this is marked as resolved, but I just tried it but did not seem to work the way I had expected.

Because it's not yet deployed. :-)