Page MenuHomePhabricator
Create Task
Maniphest T97490

Empty API response from http://commons.wikimedia.org/
Closed, ResolvedPublic
Actions

Description

The problematic url is:

http://commons.wikimedia.org/w/api.php?action=query&format=json&continue=-%7C%7C&rccontinue=20150428193830%7C164017206&list=recentchanges&rclimit=500&rcnamespace=0%7C2%7C4%7C6%7C10%7C14%7C828&rcprop=comment%7Cflags%7Cids%7Cloginfo%7Csizes%7Ctimestamp%7Ctitle%7Cuser

The response is empty.

Details

SubjectRepoBranchLines +/-
API: ApiResult must validate even when using numeric auto-indexesmediawiki/coreREL1_25+94 -4
API: ApiResult must validate even when using numeric auto-indexesmediawiki/corewmf/1.26wmf3+94 -4
API: ApiResult must validate even when using numeric auto-indexesmediawiki/coremaster+94 -4
Customize query in gerrit

Related Objects

Event Timeline

LinJin created this task.Apr 28 2015, 11:10 PM
LinJin raised the priority of this task from to Needs Triage.
LinJin updated the task description. (Show Details)
LinJin subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 28 2015, 11:10 PM
Aklapper renamed this task from Strange API response from http://commons.wikimedia.org/ . to Empty API response from http://commons.wikimedia.org/.Apr 29 2015, 9:04 AM
Aklapper added a project: MediaWiki-Action-API.
Aklapper set Security to None.

Seems to work without the &rccontinue=20150428193830|164017206 ?

LinJin added a comment.Apr 29 2015, 10:26 AM

Another example: http://commons.wikimedia.org/w/api.php?action=query&format=json&continue=-%7C%7C&rccontinue=20150429100355%7C164066635&list=recentchanges&rclimit=433&rcnamespace=0%7C2%7C4%7C6%7C10%7C14%7C828&rcprop=comment%7Cflags%7Cids%7Cloginfo%7Csizes%7Ctimestamp%7Ctitle%7Cuser .

Anomie claimed this task.Apr 29 2015, 2:46 PM
Anomie subscribed.

There's a code path where the UTF-8 normalization wasn't being done, and there's a log entry in there that has a truncated UTF-8 character. Under HHVM, this makes json_encode fail the whole string.

gerritbot subscribed.Apr 29 2015, 2:46 PM

Change 207450 had a related patch set uploaded (by Anomie):
API: ApiResult must validate even when using numeric auto-indexes

https://gerrit.wikimedia.org/r/207450

gerritbot added a project: Patch-For-Review.Apr 29 2015, 2:46 PM
Anomie added a project: Reading-Infrastructure-Team-Old (Don't use).Apr 29 2015, 2:46 PM
Anomie moved this task from Unsorted to Needs Review on the MediaWiki-Action-API board.
Anomie added a project: MW-1.25-release.
Anomie mentioned this in T96570: Backport API format changes and follow-ups to REL1_25 branch.
Anomie moved this task from Backlog to Needs Review/Feedback on the Reading-Infrastructure-Team-Old (Don't use) board.
gerritbot added a comment.Apr 29 2015, 2:58 PM

Change 207456 had a related patch set uploaded (by Anomie):
API: ApiResult must validate even when using numeric auto-indexes

https://gerrit.wikimedia.org/r/207456

gerritbot added a comment.Apr 29 2015, 3:05 PM

Change 207450 merged by jenkins-bot:
API: ApiResult must validate even when using numeric auto-indexes

https://gerrit.wikimedia.org/r/207450

Anomie mentioned this in rMWce6e288ee85f: API: ApiResult must validate even when using numeric auto-indexes.Apr 29 2015, 3:06 PM
gerritbot added a comment.Apr 29 2015, 3:29 PM

Change 207463 had a related patch set uploaded (by Chad):
API: ApiResult must validate even when using numeric auto-indexes

https://gerrit.wikimedia.org/r/207463

gerritbot added a comment.Apr 29 2015, 3:29 PM

Change 207456 merged by jenkins-bot:
API: ApiResult must validate even when using numeric auto-indexes

https://gerrit.wikimedia.org/r/207456

Anomie mentioned this in rMW9c56c1ee5e94: API: ApiResult must validate even when using numeric auto-indexes.Apr 29 2015, 3:29 PM
Anomie closed this task as Resolved.Apr 29 2015, 3:31 PM

Fixed and backported.

gerritbot added a comment.Apr 29 2015, 4:40 PM

Change 207463 merged by jenkins-bot:
API: ApiResult must validate even when using numeric auto-indexes

https://gerrit.wikimedia.org/r/207463

• demon mentioned this in rMWd04a896caa39: API: ApiResult must validate even when using numeric auto-indexes.Apr 29 2015, 4:40 PM
Anomie moved this task from Needs Review/Feedback to Done on the Reading-Infrastructure-Team-Old (Don't use) board.Apr 29 2015, 6:57 PM
• Fjalapeno edited projects, added Product-Infrastructure-Team-Backlog-Deprecated; removed Reading-Infrastructure-Team-Old (Don't use).Jun 7 2017, 2:58 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL