Maniphest T97501

Missing checkboxes for tag editing on log entries
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	PeterBowman
	Apr 29 2015, 1:32 AM

Tags

Referenced Files

	F158387: tags1.png
	Apr 29 2015, 1:32 AM

	F158389: tags2.png
	Apr 29 2015, 1:32 AM

Subscribers

Jdforrester-WMF

Description

Go to [[Special:Log]] on any 1.26wmf3 wiki. Ensure you are not granted the deleterevision right.
Despite showing an "Edit tags..." button, there is no possibility to select an entry because of the lack of checkboxes (like those on history pages). Screenshot from test.wikipedia.org:

tags1.png (670×1 px, 294 KB)

This is the same special page on another wiki as seen by an user with sysop rights, including deleterevision (tested on pl.wiktionary.org):

tags2.png (664×1 px, 273 KB)

The ability to delete revision/log entries seems to force the checkboxes to be displayed.

Details

	Subject	Repo	Branch	Lines +/-
	ChangeTags: Show checkbox on Special:Log when user lacks RevDel rights	mediawiki/core	REL1_25	+22 -9
	ChangeTags: Show checkbox on Special:Log when user lacks RevDel rights	mediawiki/core	master	+22 -9

Customize query in gerrit

Related Objects

Mentioned In: rMWb6766a8b5c60: ChangeTags: Show checkbox on Special:Log when user lacks RevDel rights
rMW48129139367f: ChangeTags: Show checkbox on Special:Log when user lacks RevDel rights

Event Timeline

PeterBowman created this task.Apr 29 2015, 1:32 AM

PeterBowman raised the priority of this task from to Needs Triage.

PeterBowman updated the task description. (Show Details)

PeterBowman added a project: MediaWiki-Change-tagging.

PeterBowman subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 29 2015, 1:32 AM

Aklapper triaged this task as High priority.Apr 29 2015, 8:53 AM

Aklapper added a project: Regression.

Aklapper set Security to None.

Legoktm added a subscriber: TTO.Apr 29 2015, 2:52 PM

Is this a regression? I never saw this code working in the first place…

Sounds like https://gerrit.wikimedia.org/r/#/c/203061/9 should've modified some of this file: https://gerrit.wikimedia.org/r/#/c/6904/1/includes/logging/LogEventsList.php

Change 207502 had a related patch set uploaded (by Anomie):
ChangeTags: Show checkbox on Special:Log when user lacks RevDel rights

https://gerrit.wikimedia.org/r/207502

gerritbot added a project: Patch-For-Review.Apr 29 2015, 5:37 PM

Thank you hugely, @Anomie. :-)

Jdforrester-WMF closed this task as Resolved.Apr 29 2015, 6:01 PM

Change 207502 merged by jenkins-bot:
ChangeTags: Show checkbox on Special:Log when user lacks RevDel rights

https://gerrit.wikimedia.org/r/207502

Anomie mentioned this in rMW48129139367f: ChangeTags: Show checkbox on Special:Log when user lacks RevDel rights.Apr 29 2015, 6:02 PM

Change 207508 had a related patch set uploaded (by Anomie):
ChangeTags: Show checkbox on Special:Log when user lacks RevDel rights

https://gerrit.wikimedia.org/r/207508

gerritbot added a project: Patch-For-Review.Apr 29 2015, 6:04 PM

Anomie added a project: MW-1.25-release.Apr 29 2015, 6:05 PM

Change 207508 merged by jenkins-bot:
ChangeTags: Show checkbox on Special:Log when user lacks RevDel rights

https://gerrit.wikimedia.org/r/207508

Anomie mentioned this in rMWb6766a8b5c60: ChangeTags: Show checkbox on Special:Log when user lacks RevDel rights.Apr 29 2015, 7:05 PM