Page MenuHomePhabricator

Missing checkboxes for tag editing on log entries
Closed, ResolvedPublic

Description

  1. Go to [[Special:Log]] on any 1.26wmf3 wiki. Ensure you are not granted the deleterevision right.
  2. Despite showing an "Edit tags..." button, there is no possibility to select an entry because of the lack of checkboxes (like those on history pages). Screenshot from test.wikipedia.org:

tags1.png (670×1 px, 294 KB)

This is the same special page on another wiki as seen by an user with sysop rights, including deleterevision (tested on pl.wiktionary.org):
tags2.png (664×1 px, 273 KB)

The ability to delete revision/log entries seems to force the checkboxes to be displayed.

Event Timeline

PeterBowman raised the priority of this task from to Needs Triage.
PeterBowman updated the task description. (Show Details)
PeterBowman added a subscriber: PeterBowman.
Aklapper added a project: Regression.
Aklapper set Security to None.

Is this a regression? I never saw this code working in the first place…

Change 207502 had a related patch set uploaded (by Anomie):
ChangeTags: Show checkbox on Special:Log when user lacks RevDel rights

https://gerrit.wikimedia.org/r/207502

Change 207502 merged by jenkins-bot:
ChangeTags: Show checkbox on Special:Log when user lacks RevDel rights

https://gerrit.wikimedia.org/r/207502

Change 207508 had a related patch set uploaded (by Anomie):
ChangeTags: Show checkbox on Special:Log when user lacks RevDel rights

https://gerrit.wikimedia.org/r/207508

Change 207508 merged by jenkins-bot:
ChangeTags: Show checkbox on Special:Log when user lacks RevDel rights

https://gerrit.wikimedia.org/r/207508