Revisions can be eliminated via GlobalRenameUser
Closed, DuplicatePublic
Actions

Assigned To

Authored By

	Xeno
	Apr 29 2015, 1:59 PM

Description

There seems to be a rather serious bug in the global rename user facility that allows destruction of revisions making them no longer available for admins to retrieve. See https://en.wikipedia.org/wiki/Wikipedia:Bureaucrats%27_noticeboard#Rather_serious_rename_bug for more details [ https://en.wikipedia.org/w/index.php?title=Wikipedia:Bureaucrats%27_noticeboard&oldid=659873109 ]

I have replicated the bug and destroyed revision 659870568 https://en.wikipedia.org/w/index.php?title=User:Test_account_042915_newname&oldid=659870568 https://en.wikipedia.org/w/index.php?title=User:Test_account_042915_newname&action=history

User moves their userpage to a desired new name
User later requests rename
Rename ends up moving the user-created redirect over the proper target and old revisions are nowhere to be found.

Expected behaviour: Old revisions would be available in the deleted edits.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T97536 GlobalRename is moving over existing pages, causing revisions to go missing (tracking)
		Duplicate		Legoktm	T97532 Revisions can be eliminated via GlobalRenameUser

Event Timeline

Xeno created this task.Apr 29 2015, 1:59 PM

Xeno assigned this task to Legoktm.

Xeno raised the priority of this task from to Unbreak Now!.

Xeno updated the task description. (Show Details)

Xeno subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 29 2015, 1:59 PM

select * from revision where rev_id = 659870568;
+-----------+----------+-------------+------------------------------------------------------------------------------------------------+----------+-----------------------------+----------------+----------------+-------------+---------+---------------+---------------------------------+-------------------+--------------------+

rev_id

rev_page

rev_text_id

rev_comment

rev_user

rev_user_text

rev_timestamp

rev_minor_edit

rev_deleted

rev_len

rev_parent_id

rev_sha1

rev_content_model

rev_content_format

659870568

46560135

[[WP:AES|←]]Created page with 'Make userpage, move to location, be renamed over the target.'

24999018

Test account 042915 newname

20150429132111

g9vf2u7oobexljx2hn2a81bamv35bnk

NULL

+-----------+----------+-------------+------------------------------------------------------------------------------------------------+----------+-----------------------------+----------------+----------------+-------------+---------+---------------+---------------------------------+-------------------+--------------------+

In T97532#1245444, @Betacommand wrote:

select * from revision where rev_id = 659870568;

Yes, that's the content; where has the revision disappeared off to?

Users requiring their revisions restored: en:user:Tabletrack , en:user:SwagMaster2030

Looks Like something caused rev_text_id to be 0 which is why it cannot be found in either deleted or non-deleted edits. But the actual revision id exists in the revision table, its just missing the associated text

Legoktm added a parent task: T97536: GlobalRename is moving over existing pages, causing revisions to go missing (tracking).Apr 29 2015, 3:28 PM

In T97532#1245599, @Betacommand wrote:

Looks Like something caused rev_text_id to be 0 which is why it cannot be found in either deleted or non-deleted edits. But the actual revision id exists in the revision table, its just missing the associated text

I think that's just labs converting it to 0?

mysql:wikiadmin@db1052 [enwiki]> select rev_text_id from revision where rev_id = 659870568;
+-------------+
| rev_text_id |
+-------------+
|   664954339 |
+-------------+
1 row in set (0.00 sec)

Looks like your right, wasnt aware of the zeroing

Aklapper added projects: MediaWiki-Revision-deletion, MediaWiki-extensions-CentralAuth.Apr 29 2015, 4:04 PM

Steinsplitter added a project: GlobalRename.Apr 29 2015, 6:33 PM

Steinsplitter set Security to None.

Keegan moved this task from Backlog to Review requested on the GlobalRename board.Apr 29 2015, 8:44 PM

Liuxinyu970226 subscribed.Apr 30 2015, 4:20 AM

Nnemo subscribed.Apr 30 2015, 12:42 PM

Stryn subscribed.Apr 30 2015, 9:15 PM

Salvidrim subscribed.Apr 30 2015, 9:42 PM

Glaisher subscribed.May 3 2015, 12:43 PM

• MZMcBride subscribed.May 3 2015, 10:26 PM

MGChecker subscribed.May 20 2015, 7:18 PM

MarcoAurelio subscribed.Jun 14 2015, 1:24 AM

Steinsplitter subscribed.Jun 14 2015, 10:49 AM

Luke081515 subscribed.Jun 23 2015, 8:57 PM

@Legoktm: Any news here (as you are assignee)? Is the priority "Unbreak now" actually realistic (as there have been no news here for two months)?

Ricordisamoa subscribed.Aug 18 2015, 6:29 AM

@Legoktm: Any news here (as you are assignee)? Is the priority "Unbreak now" actually realistic (as there have been no news here for four months)?

Luke081515 unsubscribed.Sep 15 2015, 4:17 PM

This shouldn't happen since https://gerrit.wikimedia.org/r/#/c/207501/. The move would just be aborted if the target exists - so lowering priority.

Glaisher removed a project: MediaWiki-Revision-deletion.Sep 28 2015, 11:24 AM

Actually, this is just a duplicate of T97536 now... unless the revisions mentioned in this task are still missing? (so that this doesn't get lost.)

@Xeno: Could you clarify? ^^

In T97532#1680428, @Glaisher wrote:

Actually, this is just a duplicate of T97536 now...

So shall this task get merged?

In T97532#1898202, @Aklapper wrote:

In T97532#1680428, @Glaisher wrote:

Actually, this is just a duplicate of T97536 now...

So shall this task get merged?