Page MenuHomePhabricator

Tiny search icon in alpha and Gather beta
Closed, ResolvedPublic

Description

So cute!!! (but probably should fix)

Screen_Shot_2015-04-30_at_9.37.17_AM.png (341×395 px, 190 KB)

http://en.m.wikipedia.beta.wmflabs.org/wiki/Headings?mobileaction=alpha
Also impacts Gather in collection edit overlay

Event Timeline

Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Web-Team-Backlog.
Jdlrobson moved this task to Incoming on the Web-Team-Backlog board.
Jdlrobson subscribed.

@Jdlrobson: Could you whack a link in the description? I've yet to see this locally or on en.m.

@Esanders @matmarex, this is caused by the same problem that hit the mobile settings link... only this time the icon oojs ui uses is correct, but the sizing does not match. The icon seems to have lots of whitespace. Can you shed some light on this?

It might be worth reconsidering updating oojs ui so it doesn't use mw-ui-icon classes - they don't seem to be compatible at the current time.

Jdlrobson renamed this task from Tiny search icon in alpha to Tiny search icon in alpha and Gather beta.Apr 30 2015, 11:45 PM

Is there a list of mw-ui icon names used by MobileFrontend? They seem to be spread over multiple files. Let's just check which ones conflict and fix them…

And the search icon in OOUI is too small relative to other icons in the theme indeed. It was copied from Apex, since apparently no one thought that one would be useful with MediaWiki UI…

Change 208062 had a related patch set uploaded (by Bartosz Dziewoński):
What is this, an icon for ants?

https://gerrit.wikimedia.org/r/208062

It was copied from Apex, since apparently no one thought that one would be useful with MediaWiki UI…

Sorry, that wasn't correct. We actually have two versions of the icon, one tiny and one normal. Updated the patch above to merge them into one.

Phew! Thanks a bunch. Gives me more confidence that our icon styles/implementation can be merged somewhere down the line. Will review very soon...

I filed T97793 to track down the conflicts.

Change 208062 merged by jenkins-bot:
Switch over 'magnifyingGlass' icon to be 'search'

https://gerrit.wikimedia.org/r/208062

Esanders claimed this task.

(This will get properly fixed in MobileFrontend when we release new OOjs UI version, and update MediaWiki core to use it.)