So cute!!! (but probably should fix)
http://en.m.wikipedia.beta.wmflabs.org/wiki/Headings?mobileaction=alpha
Also impacts Gather in collection edit overlay
So cute!!! (but probably should fix)
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Switch over 'magnifyingGlass' icon to be 'search' | oojs/ui | master | +40 -15 |
@Jdlrobson: Could you whack a link in the description? I've yet to see this locally or on en.m.
@Esanders @matmarex, this is caused by the same problem that hit the mobile settings link... only this time the icon oojs ui uses is correct, but the sizing does not match. The icon seems to have lots of whitespace. Can you shed some light on this?
It might be worth reconsidering updating oojs ui so it doesn't use mw-ui-icon classes - they don't seem to be compatible at the current time.
Is there a list of mw-ui icon names used by MobileFrontend? They seem to be spread over multiple files. Let's just check which ones conflict and fix them…
And the search icon in OOUI is too small relative to other icons in the theme indeed. It was copied from Apex, since apparently no one thought that one would be useful with MediaWiki UI…
Change 208062 had a related patch set uploaded (by Bartosz Dziewoński):
What is this, an icon for ants?
It was copied from Apex, since apparently no one thought that one would be useful with MediaWiki UI…
Sorry, that wasn't correct. We actually have two versions of the icon, one tiny and one normal. Updated the patch above to merge them into one.
Phew! Thanks a bunch. Gives me more confidence that our icon styles/implementation can be merged somewhere down the line. Will review very soon...
Change 208062 merged by jenkins-bot:
Switch over 'magnifyingGlass' icon to be 'search'
(This will get properly fixed in MobileFrontend when we release new OOjs UI version, and update MediaWiki core to use it.)