| Jdlrobson | |
| Apr 30 2015, 6:24 PM |
| F172623: Screen Shot 2015-06-01 at 1.36.07 PM.png | |
| Jun 1 2015, 8:34 PM |
| F172617: Screenshot 2015-06-01 11.25.29.png | |
| Jun 1 2015, 8:07 PM |
| F169162: Screen Shot 2015-05-25 at 11.06.18 PM.png | |
| May 25 2015, 9:04 PM |
| F161725: searchflow-02.png | |
| May 7 2015, 10:47 PM |
| F158976: searchflow-02.png | |
| Apr 30 2015, 6:24 PM |
| F158981: searchflow-04.png | |
| Apr 30 2015, 6:24 PM |
| F158979: searchflow-03.png | |
| Apr 30 2015, 6:24 PM |
@KHammerstein what about the public/private setting? It seems strange that we are putting this where nobody would think to find it. I am fine with this as a short term solution, but at some point we might need a separate settings page. Perhaps we use a gear instead of a pencil? or put public/private/hidden in the first page?
Change 211919 had a related patch set uploaded (by Jhernandez):
UX changes to the collection editing overlay
@Jdlrobson, @Jhernandez I don't see this on wmflabs. Really want to get the pts up to 6 for this sprint, though :)
I see it in chrome, but not in iOS (probably a cache thing).
@KHammerstein can you sign off on design element?
fyi @Jdlrobson
I suspect this is related to changes @kaldari @bmansurov and @phuedx made... guys, what do we need to do to make the width normal?
@KHammerstein the cog icon is tied to mobile options. It seems VisualEditor use a different icon for settings
The problem is in the Gather codebase. You're not supposed to wrap an ".overlay-header" with an ".overlay-header".
@Jdlrobson
"what about the public/private setting? It seems strange that we are putting this where nobody would think to find it. I am fine with this as a short term solution, but at some point we might need a separate settings page. Perhaps we use a gear instead of a pencil? or put public/private/hidden in the first page?" -JKatzWMF
Lets use the cog icon, I'll try to find an updated version
@bmansurov You're right it seems that this class doesn't belong on the container itself (note it's not a case of 'supposed to' - it's just not working because we didn't intend to support that. Thanks for pointing out the issue.
@KHammerstein and @JKatzWMF can you create a separate card to capture the settings page please rather than commenting on this bug?
I'm going to have a stab at:
Please anything else discuss it and when clear raise a task.
Change 215368 had a related patch set uploaded (by Jhernandez):
Fix headers on desktop when editing a collection
Change 215369 had a related patch set uploaded (by Jhernandez):
Edit icon goes in title when description is empty.
Please review these two:
- 1. Header is broken in desktop (https://gerrit.wikimedia.org/r/215368)
- 2. Pencil icon on title when description empty (https://gerrit.wikimedia.org/r/215369)
Created this task about changing to cog icon and making it more a settings page T101202
Change 215368 merged by jenkins-bot:
Fix headers on desktop when editing a collection
Change 215369 merged by jenkins-bot:
Edit icon goes in title when description is empty.
@KHammerstein can you move it to Done if it is verified? https://phabricator.wikimedia.org/tag/mobile-web-sprint-48-voyage-of-the-damned/
