Page MenuHomePhabricator

Only show edit-change-tags UI if editable change tags are defined
Closed, ResolvedPublic

Description

It's pointless to have checkboxes and buttons that can't be used.

Event Timeline

Anomie raised the priority of this task from to Needs Triage.
Anomie updated the task description. (Show Details)
Anomie added subscribers: Anomie, TTO.

Change 208109 had a related patch set uploaded (by Anomie):
ChangeTags: Don't show UI when no editable tags exist

https://gerrit.wikimedia.org/r/208109

Can't you use them to add arbitrary tags? I thought that was the whole point of this feature.

Can't you use them to add arbitrary tags? I thought that was the whole point of this feature.

No, that would let users screw around with tags like "hhvm" or "mobile-edit".

Wiki sysops have to go to Special:Tags and "create" a tag for user-editing before it can be applied using this feature. This also helps make sure that the tag description message gets created, etc.

Change 208109 merged by jenkins-bot:
ChangeTags: Don't show UI when no editable tags exist

https://gerrit.wikimedia.org/r/208109

Change 208110 had a related patch set uploaded (by Anomie):
ChangeTags: Don't show UI when no editable tags exist

https://gerrit.wikimedia.org/r/208110

Change 208112 had a related patch set uploaded (by Anomie):
ChangeTags: Don't show UI when no editable tags exist

https://gerrit.wikimedia.org/r/208112

Change 208113 had a related patch set uploaded (by Anomie):
ChangeTags: Don't show UI when no editable tags exist

https://gerrit.wikimedia.org/r/208113

Anomie claimed this task.

Fixed, and being backported now so people can concentrate on real issues instead of "useless buttons confusing people".

Change 208113 merged by jenkins-bot:
ChangeTags: Don't show UI when no editable tags exist

https://gerrit.wikimedia.org/r/208113

Change 208112 merged by jenkins-bot:
ChangeTags: Don't show UI when no editable tags exist

https://gerrit.wikimedia.org/r/208112

Change 208110 merged by jenkins-bot:
ChangeTags: Don't show UI when no editable tags exist

https://gerrit.wikimedia.org/r/208110