Page MenuHomePhabricator
Create Task
Maniphest T97773

Only show edit-change-tags UI if editable change tags are defined
Closed, ResolvedPublic
Actions

Description

It's pointless to have checkboxes and buttons that can't be used.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
ChangeTags: Don't show UI when no editable tags existmediawiki/coreREL1_25+26 -8
ChangeTags: Don't show UI when no editable tags existmediawiki/corewmf/1.26wmf3+47 -16
ChangeTags: Don't show UI when no editable tags existmediawiki/corewmf/1.26wmf4+26 -8
ChangeTags: Don't show UI when no editable tags existmediawiki/coremaster+26 -8
Customize query in gerrit

Related Objects

Event Timeline

Anomie created this task.May 1 2015, 3:00 PM
Anomie raised the priority of this task from to Needs Triage.
Anomie updated the task description. (Show Details)
Anomie added a project: MediaWiki-Change-tagging.
Anomie added subscribers: Anomie, TTO.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 1 2015, 3:00 PM
gerritbot subscribed.May 1 2015, 3:12 PM

Change 208109 had a related patch set uploaded (by Anomie):
ChangeTags: Don't show UI when no editable tags exist

https://gerrit.wikimedia.org/r/208109

gerritbot added a project: Patch-For-Review.May 1 2015, 3:12 PM
Jdforrester-WMF subscribed.May 1 2015, 3:15 PM

Can't you use them to add arbitrary tags? I thought that was the whole point of this feature.

Anomie mentioned this in T97013: Restrict changetags userright to sysops, edit filter managers and bots on enwiki.EditedMay 1 2015, 3:16 PM
In T97773#1251976, @Jdforrester-WMF wrote:

Can't you use them to add arbitrary tags? I thought that was the whole point of this feature.

No, that would let users screw around with tags like "hhvm" or "mobile-edit".

Wiki sysops have to go to Special:Tags and "create" a tag for user-editing before it can be applied using this feature. This also helps make sure that the tag description message gets created, etc.

Steinsplitter subscribed.May 1 2015, 3:19 PM
gerritbot added a comment.May 1 2015, 3:30 PM

Change 208109 merged by jenkins-bot:
ChangeTags: Don't show UI when no editable tags exist

https://gerrit.wikimedia.org/r/208109

Anomie mentioned this in rMWa2415baa1a3c: ChangeTags: Don't show UI when no editable tags exist.May 1 2015, 3:30 PM
gerritbot added a comment.May 1 2015, 3:32 PM

Change 208110 had a related patch set uploaded (by Anomie):
ChangeTags: Don't show UI when no editable tags exist

https://gerrit.wikimedia.org/r/208110

gerritbot added a comment.May 1 2015, 3:38 PM

Change 208112 had a related patch set uploaded (by Anomie):
ChangeTags: Don't show UI when no editable tags exist

https://gerrit.wikimedia.org/r/208112

gerritbot added a comment.May 1 2015, 3:38 PM

Change 208113 had a related patch set uploaded (by Anomie):
ChangeTags: Don't show UI when no editable tags exist

https://gerrit.wikimedia.org/r/208113

Anomie closed this task as Resolved.May 1 2015, 3:44 PM
Anomie claimed this task.

Fixed, and being backported now so people can concentrate on real issues instead of "useless buttons confusing people".

gerritbot added a comment.May 1 2015, 3:49 PM

Change 208113 merged by jenkins-bot:
ChangeTags: Don't show UI when no editable tags exist

https://gerrit.wikimedia.org/r/208113

Anomie mentioned this in rMWaba1c6135d18: ChangeTags: Don't show UI when no editable tags exist.May 1 2015, 3:49 PM
gerritbot added a comment.May 1 2015, 3:54 PM

Change 208112 merged by jenkins-bot:
ChangeTags: Don't show UI when no editable tags exist

https://gerrit.wikimedia.org/r/208112

Anomie mentioned this in rMWd2d43a005154: ChangeTags: Don't show UI when no editable tags exist.May 1 2015, 3:54 PM
Anomie mentioned this in T20670: Create ability to add / remove tags from edits / actions.May 1 2015, 3:58 PM
gerritbot added a comment.May 1 2015, 4:17 PM

Change 208110 merged by jenkins-bot:
ChangeTags: Don't show UI when no editable tags exist

https://gerrit.wikimedia.org/r/208110

Anomie mentioned this in rMWfff67108ec49: ChangeTags: Don't show UI when no editable tags exist.May 1 2015, 4:17 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits