Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Consistent list design. | apps/android/wikipedia | master | +176 -432 |
Details
Related Objects
Event Timeline
Pending:
-Type scale specification for CSS.
-Deep dive into the specific template with the developer who works on this.
-Attach an RTL view
Any idea who might be picking this card up? I would like to touch base and discuss the type scale if possible.
@Vibhabamba I have my eye on this one, but let's have a chat about scope and what specifically you're looking for. Ping me on IRC anytime.
@Vibhabamba and I had a discussion about the correct alignment of RTL and LTR text fields, and here's the result:
- If the system language is LTR, then all text fields should be left-aligned (whether or not the text itself is LTR or RTL).
- If the system language is RTL, then all text fields should be right-aligned (whether or not the text itself is LTR or RTL).
The above is consistent with how the Android OS itself handles RTL content, and improves the visual flow of the app.
Hint: to accomplish the above behavior, all text fields should have these attributes:
android:gravity="start" android:textDirection="anyRtl" android:textAlignment="viewStart"
(note: the "anyRtl" property handles cases where there is mixed LTR and RTL text within the same text field.)
Change 217130 had a related patch set uploaded (by Dbrant):
[WIP] Consistent list design.
Design Notes:
Let's remove the alphabet markers in the list view.
Currently: Search, Recent, Saved, Similar Pages, Read more will be consistent.
Nearby will have a slightly taller cell height.
Played with this in the latest alpha. Looks great. Waiting on one answer regarding height of the 'search this list' field from @Dbrant.
Discussed this with Dmitry, He is waiting on code review for a patch which makes search field height consistent with this mock.