Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Tool: Support icon+label in bar tool groups | oojs/ui | master | +23 -4 |
Details
Related Objects
Event Timeline
James, Trevor, just how "high" priority is this? We can trivially add a boolean flag displayBothIconAndLabel if we need it now and can take the tech debt. I would rather not spend time doing a bigger rewrite/cleanup right now.
I am surprised that this doesn't exist :) @matmarex i am in favor of a quick fix than bigger rewrite. This is needed for VE A/B test. we can do without it for the usability test but needed for the A/B test.
We can create a separate bucket of rewrites needed for OOJS UI and add this to it. keep tracking it. not sure if that's the best way to go about it, i know. it might create a habit of doing small fixes in future instead of fixing bigger problems but at least we can track it. you can add the button rewrite in the same bucket.
it might create a habit of doing small fixes in future instead of fixing bigger problems but at least we can track it.
We already have that habit. The toolbar stuff surely must have more hacks and workarounds in it than actual code at this point.
This is needed for VE A/B test. we can do without it for the usability test but needed for the A/B test.
The time difference between the two is 1 or 2 days, if the "quick" fix is more than that, we can keep this on normal priority.
Change 210222 had a related patch set uploaded (by Bartosz Dziewoński):
Support icon label in tools in bar tool groups