Maniphest T97883

Reject summary for FlaggedRevs gets cut of badly for multibyte chars
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	May 2 2015, 7:45 AM

Tags

Referenced Files

None

Subscribers

Description

Creating new task for reopen of T85700:

The following edit does not show a edit summary:
https://ru.wikipedia.org/w/index.php?title=Теперь_его_дозор_окончен&diff=70530965&oldid=70479606

Looking at the api: https://ru.wikipedia.org/w/api.php?action=query&prop=revisions&revids=70530965&format=xml
shows the text from message revreview-reject-summary-cur.

The creation of the revision needs a call of Language::truncate to be sure that mulitbyte characters get cuts not in the middle, resulting in missing comment (that is T95353)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Truncate for whole multibyte characters	mediawiki/extensions/FlaggedRevs	master	+7 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Umherirrender	T85700 Long edit comments get entirely removed instead of truncated (error in cutting multibyte chars?)
		Resolved		Umherirrender	T97883 Reject summary for FlaggedRevs gets cut of badly for multibyte chars

Event Timeline

Umherirrender created this task.May 2 2015, 7:45 AM

Umherirrender raised the priority of this task from to Needs Triage.

Umherirrender updated the task description. (Show Details)

Umherirrender added a project: FlaggedRevs.

Umherirrender subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 2 2015, 7:45 AM

Umherirrender mentioned this in T85700: Long edit comments get entirely removed instead of truncated (error in cutting multibyte chars?).May 2 2015, 7:46 AM

MBH subscribed.May 2 2015, 8:00 AM

Umherirrender added a parent task: T85700: Long edit comments get entirely removed instead of truncated (error in cutting multibyte chars?).May 2 2015, 6:12 PM

Liuxinyu970226 subscribed.May 22 2015, 12:40 AM

Aklapper triaged this task as Low priority.Jun 30 2015, 2:10 PM

Change 329609 had a related patch set uploaded (by Umherirrender):
Truncate for whole multibyte characters

https://gerrit.wikimedia.org/r/329609

gerritbot added a project: Patch-For-Review.Dec 29 2016, 2:51 PM

Umherirrender claimed this task.Dec 29 2016, 2:52 PM

After the patch is deployed (January 17-19), new edits should not be affected by this issue.

Change 329609 merged by jenkins-bot:
Truncate for whole multibyte characters

https://gerrit.wikimedia.org/r/329609

(Actually, it should be fixed for existing edits too, per T95353.)

ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)).Jan 4 2017, 10:00 PM

Liuxinyu970226 unsubscribed.Jan 5 2017, 12:46 PM