Page MenuHomePhabricator
Create Task
Maniphest T97902

GlobalRename fails when Antispoof is not enabled
Closed, ResolvedPublic
Actions

Description

Currently when a global rename is attempted while AntiSpoof is not enabled, a fatal error occurs. It should either show a message like it currently does for RenameUser or it should work without AntiSpoof's functionality.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
GlobalRename: Don't fatal if AntiSpoof isn't enabledmediawiki/extensions/CentralAuthmaster+6 -4
Customize query in gerrit

Related Objects

Event Timeline

Glaisher created this task.May 2 2015, 4:20 PM
Glaisher raised the priority of this task from to Low.
Glaisher updated the task description. (Show Details)
Glaisher added a project: GlobalRename.
Glaisher subscribed.
Restricted Application added a project: MediaWiki-extensions-CentralAuth. · View Herald TranscriptMay 2 2015, 4:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.May 15 2015, 6:52 PM

Change 211148 had a related patch set uploaded (by Legoktm):
GlobalRename: Don't fatal if AntiSpoof isn't enabled

https://gerrit.wikimedia.org/r/211148

gerritbot added a project: Patch-For-Review.May 15 2015, 6:52 PM
Legoktm claimed this task.May 15 2015, 7:03 PM
gerritbot added a comment.May 15 2015, 8:23 PM

Change 211148 merged by jenkins-bot:
GlobalRename: Don't fatal if AntiSpoof isn't enabled

https://gerrit.wikimedia.org/r/211148

Diffusion mentioned this in rMEXTa3571a193bb9: Updated mediawiki/extensions Project: mediawiki/extensions/CentralAuth….May 15 2015, 8:23 PM
Legoktm mentioned this in rECAU20dd05a22e79: GlobalRename: Don't fatal if AntiSpoof isn't enabled.May 15 2015, 8:24 PM
Aklapper added a comment.May 20 2015, 1:34 PM

@Legoktm: Change merged; anything left to do here?

Legoktm closed this task as Resolved.May 20 2015, 3:43 PM

Nope! :)

MarcoAurelio moved this task from Backlog to Done on the MediaWiki-extensions-CentralAuth board.May 25 2015, 11:47 PM
Keegan moved this task from Backlog to Closed on the GlobalRename board.Jun 7 2015, 1:46 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits