Page MenuHomePhabricator
Create Task
Maniphest T97939

Jobrunner OOMs in jobchron before sending the redis commands to undelay jobs
Closed, ResolvedPublic
Actions

Description

This was mentioned on https://gerrit.wikimedia.org/r/#/c/208397/.

https://gerrit.wikimedia.org/r/#/c/208408/ fixes this but resulted in too much CPU time on the servers. Oddly enough it used batches of 500 instead of the 1000 from the prior code, which somehow worked before the OOM problem.

Details

SubjectRepoBranchLines +/-
Added PeriodicScriptParamsIterator class to avoid OOMsmediawiki/services/jobrunnermaster+294 -105
Customize query in gerrit

Related Objects
Search...

Event Timeline

aaron created this task.May 3 2015, 3:33 PM
aaron raised the priority of this task from to Needs Triage.
aaron updated the task description. (Show Details)
aaron subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 3 2015, 3:33 PM
aaron added a project: WMF-JobQueue.May 3 2015, 3:33 PM
aaron set Security to None.
aaron added a subscriber: hoo.
JanZerebecki subscribed.May 3 2015, 4:31 PM
hoo triaged this task as High priority.May 4 2015, 10:30 PM
hoo merged a task: T97907: Page moves don't get processed to Wikidata.
hoo added subscribers: Lydia_Pintscher, Sjoerddebruin.
Legoktm subscribed.Jun 1 2015, 10:03 PM
gerritbot subscribed.Jun 1 2015, 10:15 PM

Change 208852 merged by jenkins-bot:
Added PeriodicScriptParamsIterator class to avoid OOMs

https://gerrit.wikimedia.org/r/208852

ori mentioned this in rGJOB917bde731f93: Added PeriodicScriptParamsIterator class to avoid OOMs.Jun 1 2015, 10:16 PM
Legoktm added a parent task: T101050: Set $wgEchoUseJobQueue = true on all Wikimedia wikis.Jun 1 2015, 11:21 PM
Catrope subscribed.Jun 2 2015, 6:46 PM
In T97939#1327302, @gerritbot wrote:

Change 208852 merged by jenkins-bot:
Added PeriodicScriptParamsIterator class to avoid OOMs

https://gerrit.wikimedia.org/r/208852

Does this patch (which was deployed yesterday) fix the bug?

aaron closed this task as Resolved.Jun 2 2015, 8:54 PM
aaron claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL