Page MenuHomePhabricator

Change 'hastemplate()' in scripts/featured.py so that it returns true for even one existing template encountered.
Closed, ResolvedPublic

Description

Presently, 'hastemplate()' in scripts/featured.py returns True only if:

  • Both the lists i.e., ('remove_tl', 'add_tl' ) are empty. L299
  • If all the templates in both the lists are existing.

But the expected behaviour should be that it returns true even if it encounters a single existing template. This is the reason probably why the script could not run while testing it with syntax:

  • 'python pwb.py scripts/featured.py -featured -fromall -family:wikipedia -lang:en'

Needs to be examined once.

Event Timeline

droid raised the priority of this task from to Needs Triage.
droid updated the task description. (Show Details)
droid added a subscriber: droid.
Restricted Application added a subscriber: Unknown Object (MLST). · View Herald TranscriptMay 4 2015, 9:39 PM

Change 208921 had a related patch set uploaded (by John Vandenberg):
hastemplate() returns true for even one existing template

https://gerrit.wikimedia.org/r/208921

Change 208921 merged by jenkins-bot:
[bugfix] hastemplate() returns true for even one existing template

https://gerrit.wikimedia.org/r/208921

Xqt claimed this task.