Page MenuHomePhabricator

Overriding DonationInterface config in mw-vagrant is difficult
Closed, ResolvedPublic

Description

According to the README in vagrant/settings.d, anything in the top-level settings directory, such as 00-debug.php, is supposed to run after all the puppet-managed files are loaded. This doesn't seem to be the case--I've created a new file 01-foo.php, and it should override $wgGlobalCollectGatewayAccountInfo but does not have any affect until I've deleted the corresponding line in vagrant/settings.d/wikis/paymentswiki/settings.d/puppet-managed/10-DonationInterface.php

Event Timeline

awight raised the priority of this task from to Needs Triage.
awight updated the task description. (Show Details)
awight added subscribers: awight, mmodell.

Discussed on https://gerrit.wikimedia.org/r/#/c/209381/3/puppet/modules/mediawiki/templates/multiwiki/CommonSettings.php.erb,unified:

The current order makes sense to me (global puppet, global user, local puppet, local user) but I could see changing it to (global puppet, local puppet, global user, local user). The problem with the later ordering is that it could lead to a user needing to jump through hoops to configure a setting that overrides things globally but excludes changing specialty wikis.

To override settings for paymentswiki specifically, put them in vagrant/settings.d/wikis/paymentswiki/settings.d/*.php. These settings will be loaded after the Puppet managed settings in vagrant/settings.d/wikis/paymentswiki/settings.d/puppet-managed/*.php

The full load order is:

  • vagrant/settings.d/puppet-managed/*.php
  • vagrant/settings.d/*.php
  • vagrant/settings.d/wikis/<wiki>/settings.d/puppet-managed/*.php
  • vagrant/settings.d/wikis/<wiki>/settings.d/*.php

Change 209533 had a related patch set uploaded (by Awight):
Explain how to override wiki-specific configuration

https://gerrit.wikimedia.org/r/209533

Change 209533 merged by jenkins-bot:
Explain how to override wiki-specific configuration

https://gerrit.wikimedia.org/r/209533

awight claimed this task.