Page MenuHomePhabricator

performance: MobileFrontend SearchApi.js query can drop list=prefixsearch and use index to sort
Closed, ResolvedPublic

Description

I copied the query in SearchApi.js' getApiData() for an article. Brad pointed out you can leave out

list: 'prefixsearch',
pssearch: query,
pslimit: 15

from the query and instead sort the elements of query.pages on their index key added in T75522: PrefixSearch should support paging.

Details

Related Gerrit Patches:
mediawiki/extensions/MobileFrontend : masterSimplify search logic for performance benefit

Event Timeline

Spage raised the priority of this task from to Needs Triage.
Spage updated the task description. (Show Details)
Spage added subscribers: Spage, MaxSem, Anomie.
Restricted Application added a project: Readers-Web-Backlog. · View Herald TranscriptMay 5 2015, 10:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jhernandez triaged this task as Medium priority.Aug 17 2015, 11:19 AM

Change 276384 had a related patch set uploaded (by Jdlrobson):
WIP: Cleanup use of prefixsearch in search

https://gerrit.wikimedia.org/r/276384

MaxSem removed a subscriber: MaxSem.Mar 10 2016, 1:27 AM
phuedx added a subscriber: phuedx.Mar 14 2016, 11:09 AM

Reviewing…

Change 276384 merged by jenkins-bot:
Simplify search logic for performance benefit

https://gerrit.wikimedia.org/r/276384

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptAug 7 2016, 6:15 PM