Page MenuHomePhabricator

null edits on Flow posts are registered in history
Closed, DuplicatePublic

Description

See https://he.wikipedia.org/w/index.php?title=%D7%A0%D7%95%D7%A9%D7%90:Sg95kjbdqbui2br5&action=history&uselang=en

The edit from 13:56, 5 May 2015 didn't change anything, but it's registered in history. I just opened a post for editing, didn't do anything and clicked the save button.

Event Timeline

Amire80 created this task.May 5 2015, 10:58 AM
Amire80 updated the task description. (Show Details)
Amire80 raised the priority of this task from to Low.
Amire80 added a project: StructuredDiscussions.
Amire80 added subscribers: Amire80, IKhitron.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMay 5 2015, 10:58 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Amire, you should give another link. This one is broken because another flow bug.

Huh? Works for me.

I get all the time database error page.

@IKhitron, if you're still getting that error, please post the text or a screenshot.

@Amire80, for now, null edits are needed to work around the fact that Flow does not automatically update posts when templates, etc. change. See T59991: Changes in templates are not immediately reflected in Flow posts which transclude those templates

However, we should revisit this after that's fixed. Possibly, in the mean time, we could only record null edits if the resulting HTML changed, if it's not already doing that.

A database query error has occurred. This may indicate a bug in the software.

* Function: Flow\Data\Storage\RevisionStorage::findInternal
* Error: 1054 Unknown column 'topic_root_id' in 'where clause' (10.64.16.18)

Can you also post the URL, and what username you were logged in with? A screenshot might also be helpful.

Seems to be another case of T91916: Database error on Flow history page. I'm not sure why it's only happening for you.

I can give you a tip: tryed now in MF, IE and GC. There is a problem only in the first one.

@IKhitron, did you try with the URL https://he.wikipedia.org/w/index.php?title=%D7%A0%D7%95%D7%A9%D7%90:Sg95kjbdqbui2br5&action=history&uselang=en&limit=500 ? I think that will fail in any browser. I think the reason it works for certain users/browsers is that they're logged out, or logged in to an account with the default limit. I expect that URL (setting an explicit limit) will fail for everyone.

Let's take further conversion about the exception to T91916: Database error on Flow history page, since the null edit issue is unrelated.