Page MenuHomePhabricator
Create Task
Maniphest T98188

Panel styling defaults are bad
Closed, ResolvedPublic
Actions

Description

In introducing the BetaOptinPanel and global panel styles I made a mistake. All panel styles should probably be limited to the opt in panel as there are regressions all over the place.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileFrontendmaster+8 -11Restrict default styling to panels in #content area
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.May 5 2015, 6:43 PM
Jdlrobson raised the priority of this task from to High.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Readers-Web-Backlog.
Jdlrobson moved this task to Incoming on the Readers-Web-Backlog board.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 5 2015, 6:43 PM
Jdlrobson merged a task: T98133: Strange panel styling when editing a collection.May 6 2015, 9:18 AM
Jdlrobson added a subscriber: Jhernandez.
Jdlrobson moved this task from Incoming to Triaged but Future on the Readers-Web-Backlog board.May 6 2015, 9:25 AM
Jdlrobson claimed this task.May 6 2015, 10:06 AM
Jdlrobson added a project: Gather Sprint Greatest Hits.
Jdlrobson set Security to None.
gerritbot added a subscriber: gerritbot.May 6 2015, 10:08 AM

Change 209194 had a related patch set uploaded (by Jdlrobson):
Restrict default styling to panels in #content area

https://gerrit.wikimedia.org/r/209194

gerritbot added a project: Patch-For-Review.May 6 2015, 10:08 AM
Jdlrobson moved this task from In Analysis to Code review needed on the Gather Sprint Greatest Hits board.May 6 2015, 10:09 AM
gerritbot added a comment.May 6 2015, 10:52 AM

Change 209194 merged by jenkins-bot:
Restrict default styling to panels in #content area

https://gerrit.wikimedia.org/r/209194

Diffusion mentioned this in rMEXT17094ec7b85b: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….May 6 2015, 10:53 AM
Jdlrobson mentioned this in rEMFR1c505d0a99c3: Restrict default styling to panels in #content area.May 6 2015, 10:53 AM
Jhernandez moved this task from Code review needed to Ready for signoff on the Gather Sprint Greatest Hits board.May 6 2015, 10:53 AM
Jdlrobson closed this task as Resolved.May 7 2015, 2:51 PM
Jdlrobson moved this task from Ready for signoff to Done on the Gather Sprint Greatest Hits board.
Phabricator_maintenance moved this task from Triaged but Future to 2014-15 Q4 on the Readers-Web-Backlog board.Mar 7 2018, 1:31 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL