Page MenuHomePhabricator
Create Task
Maniphest T98202

[Regression pre-wmf5] Link inspector should not have red highlight when still empty
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
matmarex
Authored By
Ryasmeen
May 5 2015, 8:07 PM
Project Tags
Referenced Files
F161544: Blue first time, red after wards.mov
May 7 2015, 2:21 PM
F160911: Screen_Shot_2015-05-05_at_1.07.35_PM.png
May 5 2015, 8:07 PM
F160909: Screen_Shot_2015-05-04_at_2.38.31_PM.png
May 5 2015, 8:07 PM
Subscribers
• Aklapper
Esanders
Jdforrester-WMF
Krinkle
Ryasmeen

Description

Steps to reproduce:

  1. Open a page with VE
  2. In an empty line, without selecting any text, click on link inspector icon from the toolbar.

Observe that, the link inspector opens with a blue highlighted border around the text field for the first time, now if you close the link inspector now and open again after this , everytime it opens red highlighted border

Expected : Red/ Blue highlight must be consistent on each time .

Screen_Shot_2015-05-04_at_2.38.31_PM.png (487×246 px, 36 KB)

Screen_Shot_2015-05-05_at_1.07.35_PM.png (321×182 px, 16 KB)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
ve.ui.LinkInspector: Clear validation state of input on 'ready'Bartosz DziewońskiVisualEditor/VisualEditormaster+5 -0
TextInputWidget: Allow override of #setValidityFlagEsandersoojs/uimaster+29 -11
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.May 5 2015, 8:07 PM
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen subscribed.
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptMay 5 2015, 8:07 PM
Ryasmeen renamed this task from [Regression pre-wmf5] Link inspector opens with a red highlight around the empty text field except the first time of every edit session to [Regression pre-wmf5] Link inspector opens with a red highlight around the empty text field except for the first time of every edit session.May 5 2015, 8:24 PM
Ryasmeen assigned this task to Esanders.
Ryasmeen set Security to None.
Jdforrester-WMF closed this task as Resolved.May 6 2015, 12:49 AM
Jdforrester-WMF subscribed.

Fixed in https://gerrit.wikimedia.org/r/#/c/208694/

Jdforrester-WMF reassigned this task from Esanders to matmarex.May 6 2015, 12:50 AM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF added projects: WMF-deploy-2015-05-06_(1.26wmf5), OOUI, OOUI (OOjs-UI-0.11.1), VisualEditor 2014/15 Q4 blockers.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q4 blockers board.
Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.May 6 2015, 12:58 AM
Ryasmeen reopened this task as Open.May 6 2015, 5:24 PM
Ryasmeen added a project: VisualEditor-MediaWiki-Links.
Jdforrester-WMF moved this task from Done to Backlog on the VisualEditor 2014/15 Q4 blockers board.May 6 2015, 5:31 PM
Krinkle renamed this task from [Regression pre-wmf5] Link inspector opens with a red highlight around the empty text field except for the first time of every edit session to [Regression pre-wmf5] Link inspector should not have red highlight when still empty.May 6 2015, 5:47 PM
Krinkle mentioned this in T98080: Irregular highlighted borders appear around the text-box inside link inspector.
Krinkle merged a task: T98080: Irregular highlighted borders appear around the text-box inside link inspector.
Krinkle added subscribers: Krinkle, Esanders.
matmarex changed the task status from Open to Stalled.May 7 2015, 2:07 PM

Was this reopened intentionally? I can no longer reproduce using steps given in description.

Ryasmeen added a comment.May 7 2015, 2:19 PM

I can still reproduce it on both Betalabs and test2.Blue highlight appearing on the first time, red every time after wards. Attaching the video capture .

Ryasmeen added a comment.May 7 2015, 2:21 PM

Blue first time, red after wards.mov5 MBDownload

matmarex changed the task status from Stalled to Open.May 7 2015, 2:26 PM
gerritbot subscribed.May 7 2015, 2:48 PM

Change 209494 had a related patch set uploaded (by Bartosz Dziewoński):
ve.ui.LinkInspector: Clear validation state of input on 'ready'

https://gerrit.wikimedia.org/r/209494

gerritbot added a project: Patch-For-Review.May 7 2015, 2:48 PM
gerritbot added a comment.May 7 2015, 3:22 PM

Change 209497 had a related patch set uploaded (by Esanders):
Allow override of setValidityFlag

https://gerrit.wikimedia.org/r/209497

gerritbot added a comment.May 7 2015, 3:51 PM

Change 209497 merged by jenkins-bot:
TextInputWidget: Allow override of #setValidityFlag

https://gerrit.wikimedia.org/r/209497

matmarex mentioned this in rGOJUe8dc149bbee9: TextInputWidget: Allow override of #setValidityFlag.May 7 2015, 3:51 PM
Catrope mentioned this in T93421: Full user auto-complete for mention inspector.May 7 2015, 6:50 PM
gerritbot added a comment.May 7 2015, 7:31 PM

Change 209494 merged by jenkins-bot:
ve.ui.LinkInspector: Clear validation state of input on 'ready'

https://gerrit.wikimedia.org/r/209494

matmarex mentioned this in rGVED1141a3fa0eea: ve.ui.LinkInspector: Clear validation state of input on 'ready'.May 7 2015, 7:33 PM
Jdforrester-WMF moved this task from TR6: Visual diffs to Blocked on the VisualEditor board.May 8 2015, 1:39 AM
Jdforrester-WMF moved this task from Backlog to Doing on the VisualEditor 2014/15 Q4 blockers board.May 8 2015, 10:28 PM
matmarex closed this task as Resolved.May 14 2015, 3:35 PM
matmarex edited projects, added: WMF-deploy-2015-05-13_(1.26wmf6), OOUI (OOjs-UI-0.11.2); removed: Patch-For-Review.
matmarex removed a subscriber: gerritbot.
Jdforrester-WMF moved this task from Doing to Done on the VisualEditor 2014/15 Q4 blockers board.May 16 2015, 5:10 PM
Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.Jun 3 2015, 9:13 PM
Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Jun 17 2015, 11:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits