Page MenuHomePhabricator
Create Task
Maniphest T98211

Provide a context item for MWNumberedExternalLinkNodes
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:
1.Open VE
2.Insert a external link
3.Insert another external link and add label to it

Compare the context menu for both the external links and observe that the context menu for the one with label has a clickable link and the other one is not

Expected: The clickability behavior should be consistent for both cases

Screen_Shot_2015-05-05_at_1.49.13_PM.png (161×379 px, 18 KB)

Details

SubjectRepoBranchLines +/-
MWNumberedExternalLinkNode: Provide a context itemmediawiki/extensions/VisualEditormaster+55 -1
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.May 5 2015, 8:49 PM
Ryasmeen assigned this task to Esanders.
Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 5 2015, 8:49 PM
Ryasmeen added a project: VisualEditor-MediaWiki-Links.May 6 2015, 5:22 PM
Ryasmeen set Security to None.
Ryasmeen triaged this task as Medium priority.May 6 2015, 7:40 PM
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.May 8 2015, 1:35 AM
Jdforrester-WMF renamed this task from The URL in the context menu of an external link is clickable after adding label to it but not otherwise to Provide a context item for MWNumberedExternalLinkNodes.Aug 13 2015, 12:55 AM
Jdforrester-WMF claimed this task.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from Freezer to Needs Discussion/Analysis on the VisualEditor board.
gerritbot subscribed.Aug 13 2015, 12:59 AM

Change 231202 had a related patch set uploaded (by Jforrester):
MWNumberedExternalLinkNode: Provide a context item

https://gerrit.wikimedia.org/r/231202

gerritbot added a project: Patch-For-Review.Aug 13 2015, 12:59 AM
Jdforrester-WMF closed this task as Resolved.Aug 17 2015, 8:08 PM
gerritbot added a comment.Aug 17 2015, 8:16 PM

Change 231202 merged by jenkins-bot:
MWNumberedExternalLinkNode: Provide a context item

https://gerrit.wikimedia.org/r/231202

Jdforrester-WMF mentioned this in rEVED31b4466d5f1d: MWNumberedExternalLinkNode: Provide a context item.Aug 17 2015, 8:16 PM
Jdforrester-WMF edited projects, added WMF-deploy-2015-08-18_(1.26wmf19); removed Patch-For-Review.Aug 18 2015, 10:36 PM
• Forrestbot added a project: WMF-deploy-2015-08-25_(1.26wmf20).Aug 19 2015, 6:02 AM
Ryasmeen added projects: Verified-in-Phase0, Verified-in-Phase2.Aug 26 2015, 11:51 PM
Jdforrester-WMF removed a project: WMF-deploy-2015-08-25_(1.26wmf20).Sep 1 2015, 4:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL