Page MenuHomePhabricator
Create Task
Maniphest T98299

Blue pointer overlay should show after editing a newly created collection
Closed, ResolvedPublic
Actions

Description

If I leave the edit overlay by hitting save, the blue pointer overlay showing the hamburger menu does not appear...but it should.

Details

SubjectRepoBranchLines +/-
Only reload page after CollectionEditOverlay if page is special.mediawiki/extensions/Gathermaster+10 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.May 6 2015, 9:46 AM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: Gather Sprint Greatest Hits, Gather.
Jdlrobson subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 6 2015, 9:46 AM
Jdlrobson moved this task from Needs triage to Product triage on the Gather board.May 6 2015, 9:46 AM
Jdlrobson moved this task from In Analysis to Ready for dev on the Gather Sprint Greatest Hits board.
• Jhernandez claimed this task.May 6 2015, 10:07 AM
• Jhernandez moved this task from Ready for dev to In development on the Gather Sprint Greatest Hits board.
• Jhernandez added a comment.May 6 2015, 10:20 AM

@Jdlrobson Seems like this happens when you actually do edits, because when we Save the page reloads. If I recall correctly this behavior was for the collection page for reloading it and showing the edits performed, but on the article page it doesn't make sense.

Should the output of this task making CollectionEditOverlay.js not reload the page when on an article page, but reload it when on the collection page?

gerritbot subscribed.May 6 2015, 10:42 AM

Change 209199 had a related patch set uploaded (by Jhernandez):
Only reload page after CollectionEditOverlay if page is special.

https://gerrit.wikimedia.org/r/209199

gerritbot added a project: Patch-For-Review.May 6 2015, 10:42 AM
• Jhernandez moved this task from In development to Code review needed on the Gather Sprint Greatest Hits board.May 6 2015, 10:43 AM
• Jhernandez added a parent task: T98027: Bring back a confirmation message when a user saves changes to collection .May 6 2015, 11:56 AM
• Jhernandez mentioned this in T98027: Bring back a confirmation message when a user saves changes to collection .
Jdlrobson moved this task from Code review needed to Ready for signoff on the Gather Sprint Greatest Hits board.May 6 2015, 12:18 PM
gerritbot added a comment.May 6 2015, 12:20 PM

Change 209199 merged by jenkins-bot:
Only reload page after CollectionEditOverlay if page is special.

https://gerrit.wikimedia.org/r/209199

Diffusion mentioned this in rMEXTd2f73bd98c7a: Updated mediawiki/extensions Project: mediawiki/extensions/Gather….May 6 2015, 12:20 PM
Jdlrobson mentioned this in rEGAT15e1a8eb21b6: Only reload page after CollectionEditOverlay if page is special..May 6 2015, 12:20 PM
• JKatzWMF closed this task as Resolved.May 6 2015, 9:27 PM
• JKatzWMF moved this task from Ready for signoff to Done on the Gather Sprint Greatest Hits board.
• JKatzWMF set Security to None.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL