Page MenuHomePhabricator
Create Task
Maniphest T98421

Echo notification bubble is never red when there's 1 notification
Closed, ResolvedPublic
Actions

Description

Right now on Mediawiki, the notification badge only turns red when you have 2 notifications or higher -- the 1 badge is always gray.

This is related to the quiet notifications change that we just released.

Related Objects

Event Timeline

DannyH created this task.May 6 2015, 11:37 PM
DannyH raised the priority of this task from to High.
DannyH updated the task description. (Show Details)
DannyH added a project: Collaboration-Team-Sprint-B-2015-05-20.
DannyH moved this task to Sprint B - ends May 27 on the Collaboration-Team-Sprint-B-2015-05-20 board.
DannyH added subscribers: DannyH, matthiasmullie.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 6 2015, 11:37 PM
DannyH assigned this task to matthiasmullie.May 6 2015, 11:37 PM
DannyH set Security to None.
gerritbot added a subscriber: gerritbot.May 7 2015, 12:04 PM

Change 209464 had a related patch set uploaded (by Matthias Mullie):
Don't repopulate cache with potentially lagging DB data

https://gerrit.wikimedia.org/r/209464

matthiasmullie added a comment.May 7 2015, 12:06 PM

I can reproduce this on mediawiki, but not on my own machine.

I'm fairly sure the problem is caused by the cache invalidation strategy & reading from potentially lagging DB slaves. Above patch should fix that.

gerritbot added a comment.May 8 2015, 6:29 PM

Change 209464 merged by jenkins-bot:
Don't repopulate cache with potentially lagging DB data

https://gerrit.wikimedia.org/r/209464

DannyH closed this task as Resolved.May 8 2015, 7:00 PM

works on beta. thanks!

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL