Maniphest T98421

Echo notification bubble is never red when there's 1 notification
Closed, ResolvedPublic
Actions

Description

Right now on Mediawiki, the notification badge only turns red when you have 2 notifications or higher -- the 1 badge is always gray.

This is related to the quiet notifications change that we just released.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/Echo	master	+10 -8	Don't repopulate cache with potentially lagging DB data

Customize query in gerrit

Related Objects

Mentioned In: rECHO6bcece22cce3: Don't repopulate cache with potentially lagging DB data
rMEXT0b4cb303b119: Updated mediawiki/extensions Project: mediawiki/extensions/Echo…

Event Timeline

DannyH created this task.May 6 2015, 11:37 PM

DannyH raised the priority of this task from to High.

DannyH updated the task description. (Show Details)

DannyH added a project: Collaboration-Team-Sprint-B-2015-05-20.

DannyH moved this task to Sprint B - ends May 27 on the Collaboration-Team-Sprint-B-2015-05-20 board.

DannyH added subscribers: DannyH, matthiasmullie.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 6 2015, 11:37 PM

DannyH assigned this task to matthiasmullie.May 6 2015, 11:37 PM

DannyH set Security to None.

DannyH added projects: Notifications, Collaboration-Team-Triage.May 7 2015, 12:00 AM

Change 209464 had a related patch set uploaded (by Matthias Mullie):
Don't repopulate cache with potentially lagging DB data

https://gerrit.wikimedia.org/r/209464

gerritbot added a project: Patch-For-Review.May 7 2015, 12:05 PM

I can reproduce this on mediawiki, but not on my own machine.

I'm fairly sure the problem is caused by the cache invalidation strategy & reading from potentially lagging DB slaves. Above patch should fix that.

matthiasmullie moved this task from Sprint B - ends May 27 to Needs Review on the Collaboration-Team-Sprint-B-2015-05-20 board.May 7 2015, 12:06 PM

Catrope moved this task from Needs Review to QA Review on the Collaboration-Team-Sprint-B-2015-05-20 board.May 8 2015, 6:28 PM

Change 209464 merged by jenkins-bot:
Don't repopulate cache with potentially lagging DB data

https://gerrit.wikimedia.org/r/209464

Diffusion mentioned this in rMEXT0b4cb303b119: Updated mediawiki/extensions Project: mediawiki/extensions/Echo….May 8 2015, 6:30 PM

matthiasmullie mentioned this in rECHO6bcece22cce3: Don't repopulate cache with potentially lagging DB data.May 8 2015, 6:30 PM

works on beta. thanks!

DannyH moved this task from QA Review to Done on the Collaboration-Team-Sprint-B-2015-05-20 board.May 8 2015, 7:00 PM

DannyH moved this task from Untriaged to Resolved on the Collaboration-Team-Triage board.May 8 2015, 7:06 PM