Maniphest T98425

OOjs UI MenuToolgroup doesn't do anything with label
Closed, DeclinedPublic
Actions

Assigned To

Authored By

	• TrevorParscal
	May 6 2015, 11:57 PM

Project Tags

Referenced Files

None

Subscribers

• TrevorParscal

Description

Shouldn't it be a tooltip or something?

Related Objects

Mentioned In: T87135: Phabricator should only notify changes to the "Security" field if it is indeed changed

Event Timeline

• TrevorParscal created this task.May 6 2015, 11:57 PM

• TrevorParscal assigned this task to • matmarex.

• TrevorParscal raised the priority of this task from to Needs Triage.

• TrevorParscal updated the task description. (Show Details)

• TrevorParscal added a project: OOUI.

• TrevorParscal subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 6 2015, 11:57 PM

Jdforrester-WMF triaged this task as Medium priority.May 6 2015, 11:58 PM

Jdforrester-WMF set Security to None.

• matmarex mentioned this in T87135: Phabricator should only notify changes to the "Security" field if it is indeed changed.May 7 2015, 1:46 PM

I think it shouldn't. The 'title' actually means 'label' in this context, and MenuToolGroup has a label indicating which of its tools are active.

Mmm, I was confused myself, but I still think it's all correct.

MenuToolGroup has a 'title' configuration option, and it works correctly like you'd expect, setting a title/tooltip on the dropdown. It also has a 'label' option, which is probably what you mean, which is ignored for the reason I mentioned above.

• matmarex renamed this task from OOjs UI MenuToolgroup doesn't do anything with title to OOjs UI MenuToolgroup doesn't do anything with label.May 8 2015, 9:25 PM

• matmarex closed this task as Declined.

Volker_E moved this task from Backlog to Invalid/Declined/Duplicate on the OOUI board.Feb 28 2017, 9:44 PM