Page MenuHomePhabricator
Create Task
Maniphest T98476

QA: Search with search in pages button test broken
Closed, DuplicatePublic
Actions

Description

https://integration.wikimedia.org/ci/view/Mobile/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/639/testReport/junit/(root)/Search/Search_with_search_in_pages_button/

It seems to break because the chrome driver clicks exactly in the center of the element and for some reason when I click in the center it doesn't actually trigger a search...

Details

SubjectRepoBranchLines +/-
Fix search in pages feature in firefoxmediawiki/extensions/MobileFrontendmaster+2 -0
Fix flakey search in pages featuremediawiki/extensions/MobileFrontendmaster+11 -4
QA: Allow more time for search test to passmediawiki/extensions/MobileFrontendmaster+4 -0
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.May 7 2015, 2:24 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Web-Team-Backlog.
Jdlrobson moved this task to 2017-18 Q4 on the Web-Team-Backlog board.
Jdlrobson subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 7 2015, 2:24 PM
Jdlrobson added a subscriber: phuedx.May 7 2015, 2:24 PM

@phuedx this and T97460 are stopping our tests for MobileFrontend from passing.

gerritbot subscribed.Jul 19 2015, 4:59 AM

Change 225673 had a related patch set uploaded (by Jdlrobson):
QA: Allow more time for search test to pass

https://gerrit.wikimedia.org/r/225673

gerritbot added a project: Patch-For-Review.Jul 19 2015, 4:59 AM
Florian closed this task as Resolved.Jul 19 2015, 12:04 PM
Florian claimed this task.
Florian reassigned this task from Florian to Jdlrobson.
Florian set Security to None.
gerritbot added a comment.Jul 19 2015, 12:06 PM

Change 225673 merged by jenkins-bot:
QA: Allow more time for search test to pass

https://gerrit.wikimedia.org/r/225673

Diffusion mentioned this in rMEXT1bdcf53b315f: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Jul 19 2015, 12:06 PM
• Konfused-Kitten mentioned this in rEMFR3aa34161f02d: QA: Allow more time for search test to pass.Jul 19 2015, 12:06 PM
• Forrestbot added a project: WMF-deploy-2015-07-21_(1.26wmf15).Jul 19 2015, 1:00 PM
Jdlrobson merged a task: T103581: QA: Search within pages button fails intermittently .Jul 24 2015, 7:22 PM
Jdlrobson reopened this task as Open.Jul 27 2015, 4:34 PM

Still breaking:
timed out after 5 seconds, waiting for {:css=>".mw-search-results", :tag_name=>"ul"} to become present (Watir::Wait::TimeoutError)
https://integration.wikimedia.org/ci/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/728/

Jdlrobson added a project: Reading-Web-Sprint-52-Zoolander.Jul 27 2015, 4:34 PM
Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-52-Zoolander board.Jul 27 2015, 6:25 PM
Jdlrobson removed Jdlrobson as the assignee of this task.Jul 27 2015, 7:12 PM

Not currently working on this. Would be great if someone could investigate! I think there is a real bug here - and sometimes clicks do not work (I encountered this whilst testing)

Jdlrobson claimed this task.Jul 27 2015, 10:23 PM
Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-52-Zoolander board.
Jdlrobson updated the task description. (Show Details)Jul 27 2015, 10:36 PM
Jdlrobson removed projects: WMF-deploy-2015-07-21_(1.26wmf15), Patch-For-Review.
Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-52-Zoolander board.Jul 27 2015, 10:57 PM
gerritbot added a comment.Jul 27 2015, 10:57 PM

Change 227367 had a related patch set uploaded (by Jdlrobson):
Fix flakey search in pages feature

https://gerrit.wikimedia.org/r/227367

gerritbot added a project: Patch-For-Review.Jul 27 2015, 10:57 PM
• bmansurov moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-52-Zoolander board.Jul 28 2015, 8:03 PM
gerritbot added a comment.Jul 28 2015, 8:06 PM

Change 227367 merged by jenkins-bot:
Fix flakey search in pages feature

https://gerrit.wikimedia.org/r/227367

• Forrestbot added a project: WMF-deploy-2015-08-04_(1.26wmf17).Jul 28 2015, 9:00 PM
• Jhernandez closed this task as Resolved.Jul 29 2015, 9:37 AM
• Jhernandez moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-52-Zoolander board.
• Jhernandez subscribed.

We're back to green! https://integration.wikimedia.org/ci/view/Mobile/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-chrome-sauce/

Re-open if this becomes an issue again.

• Konfused-Kitten mentioned this in rEMFRe020e7136675: Fix flakey search in pages feature.Jul 30 2015, 10:12 PM
Diffusion mentioned this in rMEXT2114a3480921: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Jul 30 2015, 10:16 PM
Jdlrobson reopened this task as Open.Aug 3 2015, 10:55 PM

It's happening again... now on Firefox exclusively. On it.

Jdlrobson added a project: Reading-Web-Sprint-53-12-Monkeys.Aug 3 2015, 10:56 PM
Jdlrobson moved this task from Needs Analysis to Doing on the Reading-Web-Sprint-53-12-Monkeys board.
Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-53-12-Monkeys board.Aug 3 2015, 11:18 PM
gerritbot added a comment.Aug 3 2015, 11:19 PM

Change 229023 had a related patch set uploaded (by Jdlrobson):
Fix search in pages feature in firefox

https://gerrit.wikimedia.org/r/229023

gerritbot added a comment.Aug 3 2015, 11:35 PM

Change 229023 merged by jenkins-bot:
Fix search in pages feature in firefox

https://gerrit.wikimedia.org/r/229023

Jdlrobson mentioned this in rEMFR4e9576bb6d5c: Fix search in pages feature in firefox.Aug 3 2015, 11:35 PM
• Konfused-Kitten mentioned this in rMEXT754af8d13c72: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Aug 3 2015, 11:36 PM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-53-12-Monkeys board.Aug 4 2015, 12:21 AM
• Jhernandez added a comment.Aug 5 2015, 11:48 AM

Build's failing but for different reasons:

https://integration.wikimedia.org/ci/view/Mobile/job/browsertests-MobileFrontend-en.m.wikipedia.beta.wmflabs.org-linux-firefox-sauce/775/

So I'm considering this fixed, thanks a lot @Jdlrobson:

Macro wikilove: you rock!

• Jhernandez closed this task as Resolved.Aug 5 2015, 11:49 AM
• Jhernandez moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-53-12-Monkeys board.
Jdlrobson closed this task as a duplicate of T155855: [1 hour] Scenario: Search with search in pages button sometimes fails.May 2 2017, 2:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL