Page MenuHomePhabricator

Add (list, title) index for Gather lists
Closed, ResolvedPublic

Description

As noted in https://gerrit.wikimedia.org/r/#/c/209123/2/includes/api/ApiQueryListPages.php, without this sorting a single list by title will require a filesort (which would be OK for small lists but there is no size limit currently and there are use cases for huge lists).

Event Timeline

Tgr raised the priority of this task from to Needs Triage.
Tgr updated the task description. (Show Details)
Tgr added a subscriber: Tgr.
Florian set Security to None.
Florian added a subscriber: Florian.

Change 209502 had a related patch set uploaded (by Gergő Tisza):
Add (gli_gl_id, gli_namespace, gli_title) index

https://gerrit.wikimedia.org/r/209502

To deploy on WMF servers, run for db in testwiki test2wiki enwiki; do mwscript sql.php --wiki=$db /srv/mediawiki/php/extensions/Gather/schema/archive/add-gli_id_ns_title.sql; done on terbium.

Not sure if the last column of the (gli_namespace, gli_title, gli_gl_id) index is still needed after this change, it seems to only be there to enforce uniqueness.

Change 209502 merged by jenkins-bot:
Add (gli_gl_id, gli_namespace, gli_title) index

https://gerrit.wikimedia.org/r/209502

This can go out with T101460 at any time.

Tgr claimed this task.

Deployed.