Page MenuHomePhabricator

BadMethodCallException on old collection
Closed, ResolvedPublic

Description

https://test.m.wikipedia.org/wiki/Special:Gather/id/21/Dolls_I_love

Exception encountered, of type "BadMethodCallException"
[cca0ab86] /wiki/Special:Gather/id/21/Dolls_I_love BadMethodCallException from line 22 of /srv/mediawiki/php-1.26wmf5/extensions/Gather/includes/models/Image.php: Call to a member function transform() on a non-object (boolean)
Backtrace:
#0 /srv/mediawiki/php-1.26wmf5/extensions/Gather/includes/specials/SpecialGather.php(135): Gather\models\Image::getThumbnail(boolean)
#1 /srv/mediawiki/php-1.26wmf5/extensions/Gather/includes/specials/SpecialGather.php(74): Gather\SpecialGather->renderUserCollection(integer)
#2 /srv/mediawiki/php-1.26wmf5/includes/specialpage/SpecialPage.php(384): Gather\SpecialGather->execute(string)
#3 /srv/mediawiki/php-1.26wmf5/includes/specialpage/SpecialPageFactory.php(582): SpecialPage->run(string)
#4 /srv/mediawiki/php-1.26wmf5/includes/MediaWiki.php(285): SpecialPageFactory::executePath(Title, RequestContext)
#5 /srv/mediawiki/php-1.26wmf5/includes/MediaWiki.php(583): MediaWiki->performRequest()
#6 /srv/mediawiki/php-1.26wmf5/includes/MediaWiki.php(432): MediaWiki->main()
#7 /srv/mediawiki/php-1.26wmf5/index.php(46): MediaWiki->run()
#8 /srv/mediawiki/w/index.php(3): include(string)
#9 {main}

It seems like in models\Image.php can receive a boolean that passes the if statement on line 22 and breaks.

Event Timeline

Jhernandez claimed this task.
Jhernandez raised the priority of this task from to High.
Jhernandez updated the task description. (Show Details)
Jhernandez moved this task to In development on the Gather Sprint Greatest Hits board.
Jhernandez added a subscriber: Jhernandez.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 7 2015, 11:22 PM

Change 209664 had a related patch set uploaded (by Jhernandez):
Fix exception if image passed to models is a boolean

https://gerrit.wikimedia.org/r/209664

Change 209664 merged by jenkins-bot:
Fix exception if image passed to models is a boolean

https://gerrit.wikimedia.org/r/209664

Jdlrobson closed this task as Resolved.May 8 2015, 6:37 PM
Jdlrobson moved this task from Ready for signoff to Done on the Gather Sprint Greatest Hits board.
Jdlrobson added a subscriber: Jdlrobson.

Guess we should get this verified on test wiki
https://test.m.wikipedia.org/wiki/Special:Gather/id/21
before signing off

When would that be? After next deployment?

@rmoen will hopefully deploy this tomorrow...