Page MenuHomePhabricator

Message dialog atop process dialog must not have aria-hidden
Closed, ResolvedPublic

Description

In VisualEditor:

  1. Insert Template with at least one required parameter (per template data).
  2. Ensure the value is empty.
  3. Attempt to save.

Expected:

"Required parameter missing" dialog is shown. This dialog should not have aria-hidden. The original template dialog should now have aria-hidden.

Actual:

Both now have aria-hidden.

At first there were two empty window managers, neither aria-hidden. Then the template dialog is opened, which marks all other top-level elements (including the second, currently empty, window manager). Then a message dialog is created, which hides all other window managers. But forgets to unhide itself.

Screen Shot 2015-05-08 at 04.05.41.png (774×898 px, 369 KB)

Event Timeline

Krinkle raised the priority of this task from to Needs Triage.
Krinkle updated the task description. (Show Details)
Krinkle added projects: OOUI, Accessibility.
Krinkle subscribed.

I would say that having two full modal dialogs is a UI problem in itself btw. :)

Volker_E set Security to None.
Volker_E subscribed.

Change 363038 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[oojs/ui@master] WindowManager: Set aria-hidden by default and change toggleAriaIsolation behavior

https://gerrit.wikimedia.org/r/363038

Volker_E edited projects, added OOUI (OOjs-UI-0.23.1); removed OOUI.
Volker_E assigned this task to Prtksxna.
Volker_E removed a project: Patch-For-Review.
Volker_E removed a subscriber: gerritbot.

Change 363038 merged by jenkins-bot:
[oojs/ui@master] WindowManager: Set aria-hidden by default and change toggleAriaIsolation behavior

https://gerrit.wikimedia.org/r/363038